Comments (25)
danbooru made some changes which seem to have broken BBB's ability to fetch/modify posts and images a couple hours ago. i suspect it was these changes:
Certain selectors on the posts page have changed:
#image-container is now .image-container.
#note-container is now .note-container.
#image-resize-link is now .image-view-original-link.
The HTML structure of notes has changed.
from decensooru.
Urghhh whyyy. What is the point of those changes aghh
Welp, thankfully at least it didn't take me too much BBB-poking to find a fix. Give the updated readme a read.
from decensooru.
It was changed so that now notes are automatically resized with the image.
from decensooru.
I don't really see what turning IDs into classes has to do with that.
from decensooru.
Well the relevant commits are danbooru/danbooru@1126147, danbooru/danbooru@87a5112 and another number of commits made in the last month, which changed a lot of the notes javascript to make it more dynamic.
from decensooru.
i am still getting the bbb error after replacing line 1631
from decensooru.
Define "BBB error".
from decensooru.
popup warnign at the top:
BBB: Post content could not be located.
post i use for testing, thumbnail works correctly via decensooru, no image appears when the post is opened
https://danbooru.donmai.us/posts/3517090
image of post and error:
https://imgur.com/ATp9UYy
from decensooru.
Ah, I didn't fully update the instructions, my bad. Should be fixed now.
from decensooru.
i think its trying to work but decensooru cleared its DB and i dont see the "force refresh of decensooru" link anywhere
from decensooru.
Assuming you have the latest version of the script, it should be in the footer, next to "Keyboard shortcuts".
from decensooru.
not showing up for me.
it is running at least according to f12 though, its just stuck on 1 DB entry and there is nothing next to keyboard shortcuts
il post again in a couple hours or days if it still hasnt updated the DB
from decensooru.
Check the source of your decensooru.user.js, make sure it matches the latest version on Github. Specifically, there should be a line $('#page-footer').append('– <a id="decensooruForceFullRefresh">Force full refresh of Decensooru</a>');
from decensooru.
reinstalling decensooru fixed it
my only remaining problems are entirely BBB problems unrelated to decensooru. (image swap, resize post etc not working)
thank you for the fixes and troubleshooting.
from decensooru.
I have replaced 2 line in BBB, but it still doesn't work.
Still the "BBB: Post content could not be located." things.
I'm using the firefox 74.0, these is no $('#page-footer').append('– <a id="decensooruForceFullRefresh">Force full refresh of Decensooru</a>');
in my decensooru_gm4.user.js.
Is that why?
from decensooru.
Just tested the GM4 version on Firefox and it worked just fine. Reinstall BBB and re-edit it; tell me if it still doesn't work after that.
from decensooru.
It works. Thank you very much.
from decensooru.
I just found that the "view original" button is gone.
https://i.imgur.com/j7AhHSy.png
And it will appear if I reinstall BBB with unedited version.
Can you fix this ? thanks.
BTW some option in BBB also doesn't work like Alternate Image Swap ,
but I don't know if it's BBB or dencensooru problem, cause unedited version also doesn't work.
from decensooru.
There is no "view original", because all images will always be displayed as originals, even if non-decensooru'd images are set to be shown as samples.
I don't know if it's BBB or dencensooru problem, cause unedited version also doesn't work.
If the unedited version of BBB doesn't work, how exactly can it be caused by Decensooru? :-/ (yes, it is caused by BBB, since it hasn't been updated after the Danbooru update)
from decensooru.
With unedited and setting "Default image width" on danbooru site, "view original" will appear.
from decensooru.
Images were fixed but notes are still gone after following main page instructions, is there any way to get them back?
from decensooru.
Notes work fine for me, and there is no code either in Decensooru or the changed BBB sections that has anything to do with them, so I'm not sure what could have happened. Do notes work on non-golden-account posts? What's your browser and Greasemonkey type (original GM, Tampermonkey, etc.)?
from decensooru.
For me notes only work on gold account images, bizarrely enough.
Firefox54 developer edition/tampermonkey.
Tried a fresh install for both scripts and followed instructions on main page but still can only see notes on gold images. I can see notes on non-gold images if I disable BBB.
from decensooru.
Well, that's a problem with BBB. However, since its maintainers seem to have departed this world and I had an edited script anyway, I decided to just upload it directly (even though this fix doesn't have anything to do with Decensooru). Install the file I just added.
from decensooru.
Whatever the issue was, that fixed it. Thanks.
from decensooru.
Related Issues (16)
- Issue Loading Certain Files HOT 2
- new preview upload moved to a new server HOT 2
- This script doesn't work, period. HOT 2
- Seems not to be functioning at all
- Firefox 68.0.1 not show text right corner HOT 4
- Nothing happens. HOT 11
- "The fucking assholes broke us once again" HOT 8
- Can't view some "Hidden" thumbnails HOT 18
- Script never pulls update batches HOT 6
- Crash when pulling full batch. HOT 5
- A lot of images won't load after Danbooru made some changes HOT 1
- Pulling full batch on every page load. HOT 2
- Thumbnails dont work HOT 4
- Some images not loading HOT 10
- Database not updating ? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from decensooru.