Coder Social home page Coder Social logo

Comments (9)

mgravell avatar mgravell commented on May 27, 2024 4

Well that sounds very bad; I'm hiding 2.1.44 while I investigate - hopefully should have a fix out today or tomorrow

from dapper.

mgravell avatar mgravell commented on May 27, 2024 2

well, I'm going to assume it isn't as exotic as that and is simply a "Marc is an idiot" thing; hopefully should be able to look on Friday (I've been completely snowed under)

from dapper.

quiian avatar quiian commented on May 27, 2024

Also ran into this, dapper attempts to parse DateOnly from column 11 instead of column 12. Code was working fine before we updated. Attempting to roll back for now.. :)

Screenshot 2024-04-15 141405
image

from dapper.

sander1095 avatar sander1095 commented on May 27, 2024

I'm running into the same issue. I stronly feel that it is related #2051 as I had my own SqlMapper.TypeHandler<DateOnly> . I feel like Dapper now ignores my custom handler and uses it's built-in one.

Perhaps it's also worth talking about that specific behaviour. Wouldn't it make more sense for Dapper to still use my own mapper, which (probably) should not have made this bug show up in my code?

from dapper.

Gondlir avatar Gondlir commented on May 27, 2024

I had almost the same problem. Tell me, do you use .NET 8 with Arm64?
Where I work there is a team that uses Dapper. They upgraded to .NET 8 with ARM64 and had problems parsing columns.
I'm not sure if this was 100% the cause but I had the same problem in a project that used dapper, after this update to .NET 8 with ARM64 the Dapper simply broke.
I think it's worth the investigation @mgravell

from dapper.

GonzaloVisma avatar GonzaloVisma commented on May 27, 2024

This is the same issue I reported in #2071

from dapper.

mgravell avatar mgravell commented on May 27, 2024

I have been unable to get a repro of this failing; for now I guess I have no choice except to revert that change, but if anyone who was seeing this problem could show a runnable repro against 2.1.44 (or similar affected), I'd be very grateful

from dapper.

Dean-NC avatar Dean-NC commented on May 27, 2024

I use 2.1.37 targeting .NET 8 with no problem for DateOnly for both records and classes. I use Microsoft.Data.SqlClient 5.1.3 (accepting the security risks and will stay on it until they split-out the basic client from Azure and Identity, mainly so it doesn't require .NET framework). I don't use any custom type mapping, and I use queries like:

connection.QueryAsync<MyRecord>("Select Id, Col2, MyDateCol From Table...")

So, I'll stay on .37. I also use Dapper.AOT, but it doesn't support DateOnly yet.

from dapper.

Dean-NC avatar Dean-NC commented on May 27, 2024

If the db column is defined with a time component like DateTime2 or DateTime, then I do get this error of being off by 1, but not if the column is defined as Date.

from dapper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.