Segfault when scrolling past the last tablet in reels about notcurses

[c4l1c0]

So i just done more testing, and apparently when i remove the top and bottom borders of the tablets using tabletmask in ncreel_options struct, the segfaults completely gone.

Enabling either top, bottom, or both, triggers the segfaults when scrolling down.

I think i'm going to disable top and bottom border as a workaround for now. Thanks!

[c4l1c0]

Update, i was experiencing segfault sometimes with no border around the tablets. This time the tablet contains longer text inside it.

If anyone experiencing this, the workaround is by incrementing the number of lines returned by tablet callback.

[c4l1c0]

I just tried adding less tablets to the reels so that the tablets never reach the bottom of the reels, and scrolling works fine, both ups and downs, circular and infinite, no errors whatsoever.

I then started to add tablets one by one, until something breaks, and when one of the tablets reached the bottom of the reel (or plane?), the whole screen shifts up and i got these errors everytime i press j or down

ncplane_cursor_move_yx:732:target y 2 >= height 2
ncplane_cursor_move_yx:732:target y 2 >= height 2
ncplane_cursor_move_yx:732:target y 2 >= height 2
ncplane_cursor_move_yx:732:target y 2 >= height 2
ncplane_cursor_move_yx:732:target y 2 >= height 2
ncplane_resize_internal:834:can't keep 3@1 rows from 3                                                                                    ncreel_redraw:725:error drawing tablet

Adding one more tablet at this point and then scrolling down gives me segfault

[dankamongmen]

ick, this likely affects my growlight tool if this is all valid. i'll look into it as soon as i can (probably not before this weekend, sadly). thanks for the high-quality report!

[c4l1c0]

Appreciate it, take it easy, cheers!

[dankamongmen]

oh that's a great find! thanks a lot, that ought make things significantly easier!

[c4l1c0]

Apparently, this is because i counted the content of the tablets wrong, hence i returned the wrong return value for the tablet callback. This is the cause of the segfaults. SOOOO DUMB!!

Thanks for the help, i'm closing this issue.

[c4l1c0]

Wait sorry, i'm a dumbass, apparently it still happens when the tablet have top and/or bottom borders.