Split issue with windows ping format in French about node-ping

[mnakalay]

I am on a French Windows 7 system

I can confirm that this:

• Doesn't work from NPM
• Works just fine with the latest Github version

[mondwan]

Ahh, issue sames with #64 . Can you upload a text version for the complete ping run from terminal? As I cannot patch this without a concrete example from french system :)

[jsdidierlaurent]

Yes sure !

ping 127.0.0.1

Envoi d’une requête 'Ping' 127.0.0.1 avec 32 octets de données :
Réponse de 127.0.0.1 : octets=32 temps<1ms TTL=128
Réponse de 127.0.0.1 : octets=32 temps<1ms TTL=128
Réponse de 127.0.0.1 : octets=32 temps<1ms TTL=128
Réponse de 127.0.0.1 : octets=32 temps<1ms TTL=128

Statistiques Ping pour 127.0.0.1:
Paquets : envoyés = 4, reçus = 4, perdus = 0 (perte 0%),
Durée approximative des boucles en millisecondes :
Minimum = 0ms, Maximum = 0ms, Moyenne = 0ms

ping 8.8.8.8

Envoi d’une requête 'Ping' 8.8.8.8 avec 32 octets de données :
Réponse de 8.8.8.8 : octets=32 temps=6 ms TTL=58
Réponse de 8.8.8.8 : octets=32 temps=6 ms TTL=58
Réponse de 8.8.8.8 : octets=32 temps=6 ms TTL=58
Réponse de 8.8.8.8 : octets=32 temps=6 ms TTL=58

Statistiques Ping pour 8.8.8.8:
Paquets : envoyés = 4, reçus = 4, perdus = 0 (perte 0%),
Durée approximative des boucles en millisecondes :
Minimum = 6ms, Maximum = 6ms, Moyenne = 6ms

[BlueBird67]

For french system @Windows 10, the simple correction (but will work only for french after that), is to modify the line 51 in lib/parser/win.js

return kvp.indexOf('ms') >= 0;

with

return kvp.indexOf('temps') >= 0;

[mondwan]

I am trying to work a way that good for existing system. Hopefully, the last choice is adding a if statement for special handling French system 2017年5月18日 18:33，"BlueBird67" <[email protected]>寫道：

…

For french system @windows 10, the simple correction (but will work only for french after that), is to modify the line 51 in lib/parser/win.js return kvp.indexOf('ms') >= 0; with return kvp.indexOf('temps') >= 0; — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#65 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADuAo76HSVmK98OW6YvSWMqE2gjIw-Erks5r7B55gaJpZM4NaAXh> .

[mondwan]

@jsdidierlaurent , can you give one more example which involves a domain name?

say, ping google.com?

[mondwan]

Please try again with the latest version in github. Thanks.

[jsdidierlaurent]

Great, it works !
Thanks !

[adamtal3]

Can this be published into npm?

[agpmilli]

It seems like the version on npm still has this issue when windows language is French.
Can the fix be pushed to npm?
Thanks.

[Sazarov]

Hey, is this fix going to be published to NPM? We're facing a similar issue with Spanish windows

[mondwan]

May I know is it fixed if you are using the latest version in github instead of npm? 在 2019年6月21日週五 21:59，Sazarov <[email protected]> 寫道：

…

Hey, is this fix going to be published to NPM? We're facing a similar issue with Spanish windows — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#65?email_source=notifications&email_token=AA5YBI22S6O2CAEWRHEOTZLP3TNCFA5CNFSM4DLIAXQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYIRKJI#issuecomment-504436005>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5YBI56LS45LOD64BNL2EDP3TNCFANCNFSM4DLIAXQQ> .