alive is always false on Windows about node-ping

[mondwan]

Please try and let us know whether there are any problems :D

[mondwan]

According to the patch here, it seems exit code for window is incorrect for unreachable host.

As I do not have a window machine, can you verify this?

[jupe]

there is bug in line https://github.com/danielzzz/node-ping/blob/master/lib/ping-promise.js#L86, for loop try to search array indexes and it should instead loop actual lines...

[mondwan]

oops. Thanks for pointing out.

[cecilia-sanare]

@mondwan Your changes are working for me on Windows 7.

[mondwan]

Close

[jlengrand]

Hi there,

Sorry to comment on a closed issue, but it looked relevant.
I have just installed and tried node-ping and it looks like alive is always false on my Windows 10 machine.

Nothing very special with my system I think (no specific charset being used).

I am using the latest version from npm. Anything I may have missed?

EDIT: I have just tried to run the test suite, and on my Windows 10 computer I have 5 tests failing out of 9. I will try to dig deeper into the issues but as I am quite new to node and javascript in general any guidance is much welcome :)

[mondwan]

Have you tried the one in github? Hopefully, the npm one does not fix this issue yet.

[jlengrand]

Hum, you are right @mondwan the version from Github indeed does not have the same issue.

Is there any way when the npm version will be fixed?

EDIT :

Alright, I have used [this SO question])(http://stackoverflow.com/questions/14187956/npm-install-from-git-in-a-specific-version) to use the master version of this repository directly in the meantime :).

Thanks for the help

[danielzzz]

@jlengrand soon, hopefuly.
@mondwan If you're ok with this I will publish a new 2.1 version shortly

[jlengrand]

@danielzzz Looking forward, thanks for the good work!

[mondwan]

No problem. Please release that patch. Thanks

[danielzzz]

v2.1 published to NPM - thanks to everyone for your contributions!