Comments (12)
Will have a look within the next days.
from reportgenerator.
I can confirm the issue is fixed in 5.2.2 on Mac OS. Thank you for the fast support!
from reportgenerator.
I can't reproduce your problem.
What line coverage does your HTML report contain?
I referring to this card in the report:
Does this indicate a coverage of 100%?
The line-rate
attribute in the Cobertura file is not relevant to evaluate if the coverage is below 100%.
ReportGenerator calculates its own line/branch/method coverage metrics. Those are relevant for the evaluation and are also visible in the HTML report.
If you like, you can also send me your Cobertura file via email: [email protected]
from reportgenerator.
here is an example cobertura file generated from a .NET project: coverage.cobertura.xml.txt
The html report shows a line coverage of 50% - but reportgenerator completes with exit code 0.
from reportgenerator.
I still can't reproduce the problem. I' m using this version: https://www.nuget.org/packages/dotnet-reportgenerator-globaltool/5.2.1
Executed command: reportgenerator -reports:coverage.cobertura.xml -targetdir:output -reporttypes:Html --minimumCoverageThresholds:lineCoverage=100
Output:
PS C:\temp> reportgenerator -reports:coverage.cobertura.xml -targetdir:output -reporttypes:Html --minimumCoverageThresholds:lineCoverage=100
2024-02-23T20:43:29: Arguments
2024-02-23T20:43:29: -reports:coverage.cobertura.xml
2024-02-23T20:43:29: -targetdir:output
2024-02-23T20:43:29: -reporttypes:Html
2024-02-23T20:43:29: --minimumCoverageThresholds:lineCoverage=100
2024-02-23T20:43:29: File '\Users\mroessler\Workspaces\Samples\ReportgeneratorLineCoverageSample\Sample\Class1.cs' does not exist (any more).
2024-02-23T20:43:29: Writing report file 'output\index.html'
2024-02-23T20:43:29: The line coverage of 50% is below the minimum threshold of 100%.
from reportgenerator.
I just realised it actually works on Windows but not Mac OS (Version 5.2.1 on both platforms).
Sorry for leaving out this information - I didn't expected this to be relevant.
from reportgenerator.
Very strange behavior.
But --minimumCoverageThresholds:branchCoverage=100
and --minimumCoverageThresholds:methodCoverage=100
do work on Mac OS?
from reportgenerator.
yes, they both work on Mac OS (and Linux) - very strange indeed.
from reportgenerator.
Is it a language thing maybe? My Mac's system language is english currently - Windows is german
from reportgenerator.
Is it a language thing maybe? My Mac's system language is english currently - Windows is german
I don't think so. And the there is no difference in the implementation between lineCoverage, branchCoverage and methodCoverage
Will try to debug on Linux (I don't have a Mac available).
from reportgenerator.
might have something to do with commandline parsing. This does NOT work on Mac:
reportgenerator -reports:coverage.cobertura.xml -targetdir:output -reporttypes:Html --minimumCoverageThresholds:lineCoverage=100
This does work :)
reportgenerator -reports:coverage.cobertura.xml -targetdir:output -reporttypes:Html XXXXX --minimumCoverageThresholds:lineCoverage=100
Same happens for minimumCoverageThresholds:methodCoverage and branchCoverage - so not lineCoverage related. It just looks like the first "--"-argument is ignored.
from reportgenerator.
Please try again with version 5.2.2. This new release should fix the issue.
from reportgenerator.
Related Issues (20)
- Issue with -reporttypes field HOT 1
- Wiki Edit HOT 1
- Unable to convert opencoverxml file into corbertura.xml file using ReportGenerator in Azure Devops Pipeline HOT 3
- Release notice confuses me. HOT 1
- Why is the reportgenerator command installed using the dotent not working? HOT 2
- Report generated is always at version 5.1.14.0 on AzureDevops HOT 1
- Allow to specify the root path HOT 1
- Question: Is the format created by the CTC++ tool supported as input for report generator? HOT 2
- MS Coverage output isn't cleaning compiler generated methods/types HOT 13
- Ability to exclude classes from Risk Hotspots HOT 6
- Error while converting jacoco report to cobertura HOT 12
- Suggestion for new report type: MarkdownTableShortSummary HOT 2
- Sonarqube format clashes with DeterministicSourcePaths=true HOT 5
- Azure DevOps task option publishCodeCoverageResults doesn't work with relative targetdir path HOT 2
- Azure pipeline failure due to dependency on NodeJS version 6 HOT 3
- Docs/readmes: add info about `minimumCoverageThresholds` HOT 2
- ReportGenerator 5.3.1 fails on self hosted azure devops agent running on Amazon Linux 2 arm64 instance (t4g) HOT 2
- Question about lcov conversion HOT 4
- Strange source file references in a HTML report from dotnet-coverage on Linux HOT 1
- 5.3.5 has broken the pipeline due to "New Exception" being thrown due to `rawName` HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reportgenerator.