Nested types are getting ignored about reportgenerator

[danielpalme]

Hi Stephen,

nested types are not ignored.
ReportGenerator processes coverage reports in the following way:

1. Collect classes of assembly (without nested classes), see line 191
2. Then every class with all nested types is processed, see line 274

That means that the summary page only shows the main classes. But if you take a look at a class report, also the nested classes are included.
E.g. have a look at ConcurrentBag. Only the main class shows up in index.htm, but nested types like Node or ThreadLocalList show coverage information as well.
See lines 837-1001 in ConcurrentBag_1.htm

[stephentoub]

Thanks for following up, Daniel! I should have been clear that there are different issues for different nested types. I can understand that it's a design choice that ones like you mentioned don't show up in the main list of types. But, for example, this code https://github.com/dotnet/corefx/blob/master/src/Common/src/Interop/Windows/BCrypt/Interop.BCryptGenRandom.cs is in System.Security.Cryptography.RandomNumberGenerator, and it's type shows up in the OpenCover output XML file, but I can't find Interop or BCrypt anywhere in the report for that library. Am I just missing it?

[danielpalme]

Can you please provide me the corresponding OpenCover XML?
Perhaps something is wrong with partial nested classes.

I have to debug this with the report.

[stephentoub]

Thanks:
http://dotnet-ci.cloudapp.net/job/dotnet_corefx_coverage_windows/lastStableBuild/artifact/bin/tests/coverage/System.Security.Cryptography.RandomNumberGenerator.Tests.coverage.xml

[danielpalme]

The problem is, that the outer class Interop does not contain any methods, constructors etc.
It only contains the nested class BCrypt.

When ReportGenerator collects the name of all classes (see my comment above), the class Interop is not taken into account, because the OpenCover report does not contain any information about this class.
Therefore the nested class BCrypt is not considered too.

I think I can change this in ReportGenerator wihin the next 2-3 days.

[stephentoub]

Thanks, Daniel.

[danielpalme]

Could you please test again with version 2.1.6.0?
It should work as expected.

I created a sample nested class myself. OpenCover tracked the wrapper class, although it did not have any members. Strange that this does not happen for your Interop class.

[stephentoub]

Thanks, @danielpalme! Seems to be fixed.