Coder Social home page Coder Social logo

Comments (8)

brian-rose avatar brian-rose commented on August 22, 2024 1

I haven't thought much about it beyond musing that acceleration with numba is probably a good idea :-)

It would be great to make some progress on #6 and add some tests to ensure that the package is portable and reproducible on different platforms. Acceleration without tests could be a recipe for trouble.

from pyrads.

brian-rose avatar brian-rose commented on August 22, 2024 1

The fortran wrapping can be a chore. The RRTMG wrapper for climlab could serve as a useful example.

from pyrads.

brian-rose avatar brian-rose commented on August 22, 2024 1

@AndrewWilliams3142 it's not pretty! If I can find some time I will take another look at #6. I do think the automation of the build is important to make this package more portable and more testable.

from pyrads.

AndrewILWilliams avatar AndrewILWilliams commented on August 22, 2024

Good point @brian-rose ! I'll start working on some tests this week.

I've also added a setup.py in #13 , which seems to work when I tried it locally. I'm not sure how to wrap fortran build though.

from pyrads.

danielkoll avatar danielkoll commented on August 22, 2024

Numba does seem to speed things up significantly -- great work @AndrewWilliams3142 !

I've added a conda env so new PyRADS users can hopefully use this out-of-the-box. @brian-rose @AndrewWilliams3142 let me know if you have any other suggestions to increase user friendliness

from pyrads.

AndrewILWilliams avatar AndrewILWilliams commented on August 22, 2024

No worries @ddbkoll , happy to help!

As @brian-rose said already, I think the next step should be to automate the fortran build ( and fully close #6 ), this will make it easier to add some unit tests as well. I did a dive into the climlab RRTMG wrapper as suggested, but I don't really know enough about conda/compilers to be able to follow the details sadly

from pyrads.

AndrewILWilliams avatar AndrewILWilliams commented on August 22, 2024

@brian-rose great! I just noticed your minimalf2py repo actually - I'll take a look at that and see if I can understand the automatic compilation process a bit better. Happy to be of help if i can

from pyrads.

brian-rose avatar brian-rose commented on August 22, 2024

Yes, that's a good place to start (and I should have mentioned earlier). I created that repo specifically to help debug some build / CI issues.

from pyrads.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.