Comments (2)
I fully agree. This one needs to go away. Probably better to just have AddMessage
!?
from libkafka-asio.
I don't like the AddMessage
method signature.
- you have to create a
Message
, call some methods to set all attributes. - depending on the use case you have to create a
MessageSet
then. - then you pass the object to the
AddMessage
method which makes a deep copy of it. - then you have to clean up the
MessageSet
and theMessage
- after that the lib will clean up the same information again.
this sounds like overhead. calling much more methods then needed. and doing some memory allocations we don't need (2*MessageSet
and theMessages
).
I think it would be better to improve theAddValue
method and maybe rename it toAddMessage
. We know all components of a Message and they are just a few:
- topic (may be given by config on produce/producer level)
- partition (may be given by config on produce/producer level)
- key (optional)
- value
the rest is calculated or can be set by config
from libkafka-asio.
Related Issues (20)
- commit history correction HOT 1
- Extract ip/name resolver to a service HOT 1
- kind of TopicPartitionBlock with maps HOT 6
- deadline handling in `ConnectionService` HOT 2
- it' will not reload meta? HOT 1
- CXX_STANDARD requires CMake 3.1+ HOT 1
- "Topic or partition does not exist on this broker" error HOT 13
- Fails to compile on Ubuntu vivid HOT 3
- What if I want to use client to connect multiple brokers? HOT 1
- Add to vcpkg
- try to build libkafka: codeblocks/tdm-gcc/windows10 but boost_root - cmake problem HOT 1
- need cmake build file for win10 without gtest HOT 1
- try to build examples in win10 mingw HOT 2
- is there a connection.max.idle.time parameter for the producer. how to add this function. thanks
- Support fetch messages according to offsets not bytes
- connect failed
- compiler errors - help! HOT 1
- The callbacks in Client do not support members HOT 4
- [Client] sending requests pretty frequent results in error "Another operation is still in progress" HOT 41
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libkafka-asio.