Coder Social home page Coder Social logo

Comments (2)

danieljoos avatar danieljoos commented on June 10, 2024

I fully agree. This one needs to go away. Probably better to just have AddMessage!?

from libkafka-asio.

DEvil0000 avatar DEvil0000 commented on June 10, 2024

I don't like the AddMessage method signature.

  1. you have to create a Message, call some methods to set all attributes.
  2. depending on the use case you have to create a MessageSet then.
  3. then you pass the object to the AddMessage method which makes a deep copy of it.
  4. then you have to clean up the MessageSet and the Message
  5. after that the lib will clean up the same information again.
    this sounds like overhead. calling much more methods then needed. and doing some memory allocations we don't need (2* MessageSet and the Messages).
    I think it would be better to improve the AddValue method and maybe rename it to AddMessage. We know all components of a Message and they are just a few:
  • topic (may be given by config on produce/producer level)
  • partition (may be given by config on produce/producer level)
  • key (optional)
  • value
    the rest is calculated or can be set by config

from libkafka-asio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.