Error parsing proto with map field about python-betterproto

[isaackogan]

The specific thing it failed with:

print(field_name, current, value)
>>> comment_quality_scores {} Entry(key=[117, 115, 101, 114, 95, 116, 121, 112, 101, 95, 114, 117, 108, 101], value=200000)

changing the map type to a string fixed the issue. some info on why this worked would help a bunch

[johanjk]

I can't reproduce the issue.

Firstly, your proto did not compile as is, had to run on the following:

syntax = "proto3";

message WebcastChatMessage {
  //Common common = 1;
  //User user = 2;
  string content = 3;
  bool visibleToSender = 4;
  //Image backgroundImage = 5;
  string fullScreenTextColor = 6;
  //Image backgroundImageV2 = 7;
  //Image giftImage = 10;
  int32 inputType = 11;
  //User atUser = 12;
  repeated EmoteWithIndex emotesList = 13;
  string contentLanguage = 14;
  int32 quickChatScene = 16;
  int32 communityFlaggedStatus = 17;
  //UserIdentity UserIdentity = 18;
  map<int32, string> CommentQualityScores = 19;

  // @EmoteWithIndex
  // proto.webcast.im.ChatMessage
  message EmoteWithIndex {
    int64 index = 1;
    //Emote emote = 2;
  }
}

No reproducible test were supplied, I tried reproducing using the following:
protoc -I . --python_betterproto_out . message.proto

from msg import WebcastChatMessage, WebcastChatMessageEmoteWithIndex

x = WebcastChatMessage(
    content='hello',
    visible_to_sender=True,
    full_screen_text_color='#ffffff',
    input_type=1,
    emotes_list=[
        WebcastChatMessageEmoteWithIndex(1),
        WebcastChatMessageEmoteWithIndex(2),
    ],
    content_language='en-US',
    quick_chat_scene=0,
    community_flagged_status=2,
    comment_quality_scores={
        1: "bad",
        2: "rude",
    }
)

y = WebcastChatMessage().parse(bytes(x))
assert x == y

print(x)
print(y)

Leading to no errors on "betterproto[compiler]>=2.0.0b6"

[isaackogan]

Hi, thanks for checking. Let me see if I'm on the latest version (I thought I am) and investigate some more.

Isaac