Comments (7)
I will fix it in a following PR ( with another way ) , wait for meπ
from gdbstub.
@gz I assume you meant read/write_register
(as opposed to read/write_registers
)?
If so, then you might find this discussion from the initial implementation PR interesting: #22 (comment)
Though now that I'm re-reading this idea a year later, I realize that there might be some easier approaches to pull off something similar... I certainly wouldn't be opposed to having stricter type-safety in these APIs, so I'm open to any ideas!
from gdbstub.
@gz if this is something you'd like fixed sooner, feel free to send a quick fixup PR. Otherwise, a fix for this will land alongside some other changes to read_register
in #85
from gdbstub.
Sent pull request, yes would be nice to have this fixed, thanks!
from gdbstub.
random thought: it might be nice to statically type-encode the size of the registers when when they're passed to the read/write_registers. One way could be to move the val: &[u8]
and dst: &mut [u8]
in some enum with the RegId and encode the length explicitly (specify as &[u8; 8] etc.)?
I'm thinking that might save some slice length checks when implementing these functions. But not sure if even possible just a thought :)
from gdbstub.
And as for the original issue: yes, rip having a size of 4 seems like an oversight in the initial #34 implementation.
Pinging @keiichiw, since this might translate to a subtle correctness issue in your implementation.
from gdbstub.
Yes I meant the single register writes with the dynamic val
and dst
slices.
from gdbstub.
Related Issues (20)
- Improved Error Type (more specificity, fewer semver hazards, etc...) HOT 1
- Clippy warnings in library code HOT 3
- Allow passing a custom initial stop reason
- [mips] "unexpected packet" packet on single step HOT 10
- Not getting any events when breakpoint is set HOT 1
- All registers are byteswapped when using lldb HOT 14
- Switch `enum Signal` to `struct Signal(pub u8)` with associated constants
- NoActiveThreads error when there are no active thread HOT 9
- Misleading comment in `state_machine`? HOT 2
- Multiprocess debugging HOT 8
- [riscv32] `PacketUnexpected` when issuing `stepi` HOT 3
- vAttach: invalid response causes command to not work HOT 6
- Remove `NoActiveThread` Error
- example_no_std doesn't build on Windows HOT 1
- Remove `SingleStepBehavior` guard rail HOT 1
- Make `QStartNoAckMode` optional HOT 1
- Options for flow control? HOT 3
- Support "ack/nack" packets for unreliable transports HOT 6
- Fails to compile for atmega328p (Arduino Uno) HOT 2
- Add APIs for generating XML on-the-fly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gdbstub.