Coder Social home page Coder Social logo

Comments (10)

drosenstark avatar drosenstark commented on May 18, 2024 2

Thank you so much. Awesome stuff!

Looking forward to trying the production version.

Note: so far this new version appears to be working well with this repo by @ryanpcmcquen

from atomic-chrome.

danhper avatar danhper commented on May 18, 2024 1

@drosenstark Hi, thanks for reporting!

I added a special handler for workflowy which simply set the value to the current text instead of
doing the usual conenteditable processing (which is needed for Gmail, for example).

I think this should fix your issue, but could you give it a try please before I publish to the Store?
To do so, run the following commands

git clone https://github.com/tuvistavie/atomic-chrome.git
npm install
npm run build

then, remove the currently installed Atomic Chrome from Chrome and from the Manage extensions page,
click on "Load unpacked extension" and select the app folder of this repository.

Thank you 😃

from atomic-chrome.

drosenstark avatar drosenstark commented on May 18, 2024 1

Sorry Daniel, didn't see your comment here. No, the issue with @ryanpcmcquen's stuff is not a problem with Atomic Chrome (though it could be solved there). Ryan's plugin modifies the contents of the contenteditable div for view only, which WF will overwrite on keydown.

So if the user hits a keydown and THEN hits the Atomic Chrome button, all is good. If the user hits the Atomic Chrome button before that, it gets the modified node.

In Summary

I think we're very good on Workflowy support for now. I'm ecstatic to have it and I think it's great. Thank you!

from atomic-chrome.

drosenstark avatar drosenstark commented on May 18, 2024

Okay, testing now, thanks...

from atomic-chrome.

drosenstark avatar drosenstark commented on May 18, 2024

[I had to install Node for this... first time for everything]

It works perfectly... thank you so much for doing this. This is a huge game changer for me!

from atomic-chrome.

danhper avatar danhper commented on May 18, 2024

Thanks for trying it out! I'll publish a new version to the store then!

from atomic-chrome.

danhper avatar danhper commented on May 18, 2024

0.2.5 should be available on the store within a few hours, thanks for the help 😄

from atomic-chrome.

drosenstark avatar drosenstark commented on May 18, 2024

Um... maybe I spoke too soon on the cooperation with @ryanpcmcquen's repo. It kind of depends when you click where. HHmmmm....

from atomic-chrome.

danhper avatar danhper commented on May 18, 2024

After checking, it seems workflowy creates a contenteditable div per bullet point,
is this is why you are having trouble?
If this is the issue, I think it is going to be rather complicated to get something working,
as this is quite an edge case.
If you want to try to work on it, I am of course open to PRs!

from atomic-chrome.

danhper avatar danhper commented on May 18, 2024

Hi, Dan,
Great, I am very happy it seems to be working fine for you.
Please feel free to reopen an issue if you find anything else that could be done better.

from atomic-chrome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.