Coder Social home page Coder Social logo

Frame support? about atomic-chrome HOT 5 CLOSED

danhper avatar danhper commented on May 18, 2024
Frame support?

from atomic-chrome.

Comments (5)

danhper avatar danhper commented on May 18, 2024

Hi, thanks for reporting!
Wow, I wonder when was the last time I heard of frame and frameset 😄
I have no idea of what could be the issue, but I will take a look!
Is the plugin is outputting something to your console?

from atomic-chrome.

pixelchutes avatar pixelchutes commented on May 18, 2024

Yes, the console output is:

Atomic Chrome does not support <frame> (yet?) content-script.js:1

from atomic-chrome.

danhper avatar danhper commented on May 18, 2024

Thank you for the details, I am going to check it out!

from atomic-chrome.

danhper avatar danhper commented on May 18, 2024

@pixelchutes This should be fixed as of 0.2.1.
document.activeElement indeed returns the frame, and not the textarea or whatever, causing the issue.

I updated to get the activeElement inside the frame,
when the current one is a frame.
Keep in mind that this will not work for cross domain frames, as AFAIK there is no way to access the underlying document.

Please reopen if you are still having issues!

Thank you!

from atomic-chrome.

pixelchutes avatar pixelchutes commented on May 18, 2024

Confirmed! Thanks @tuvistavie (especially for the quick turnaround!)

from atomic-chrome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.