Comments (12)
It would be awesome. I'm not using gitlab, but it should be possible if gitlab offers html with blame information (github: https://github.com/wojteklu/danger-mention/blame/master/lib/version.rb). Then we will use regex to analyze the outputted html.
from danger-mention.
Yeah should be possible with any problems :)
from danger-mention.
Quick question. Where does branch_for_base
come from here https://github.com/k0nserv/danger-mention/blob/master/lib/danger_plugin.rb#L64? I can't find it, is it provided by Danger?
from danger-mention.
Found the answer to my own question :)
from danger-mention.
Just to be explicit: branch_for_base
is only available when you're building with github. GitLab uses branch_for_merge
.
from danger-mention.
That seems like a bug? Should they not be the same? cc @orta
from danger-mention.
Same would be better, currently gitlab has less branch_for_x
and different named ones ( I think I named them after the git terminology, so it should be fine to apply to both )
http://danger.systems/reference.html
from danger-mention.
Yeah that's my bad, I think I based my GitLab work on the GitHub plugin, but maybe I didn't. I'll make a backwards compatible PR that introduces the same names
from danger-mention.
Rockin'
from danger-mention.
Once Danger supports GitLab CI (or rather, GitLab CI supports Danger
If there's anything we can do to help we'd be more than willing :)
from danger-mention.
This is added in 0.6.0 and shipped just now
from danger-mention.
I take this back, as it uses web-page scraping #11 , I don't think the changes I've added are enough for gitlab support
from danger-mention.
Related Issues (10)
- Better strategy of downloading blame information HOT 1
- Private repositories support HOT 8
- Invalid `Dangerfile` file: 401 Unauthorized HOT 2
- [!] Invalid `Dangerfile` file: 404 Not Found HOT 2
- Allow users to supply a CODEOWNERS file to configure danger-mention HOT 1
- Missing blame information (Gitlab CI and docker)
- Add to danger.systems HOT 2
- Use GitHub request Reviewers feature HOT 1
- Something wrong with branch_for_base call (CircleCI) HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from danger-mention.