Comments (5)
I've added some comments in your PR to confirm some things. Get back to me when you can!
from charts.
When will this be merged, as it is now impossible to add more than one SAVE instruction in the redis.config
from charts.
@fveerden Sorry, I completely missed @SarjakSShah response to my original suggestions.
Right now, I'm torn between what options we offer here without bringing more unnecessary complexity into the chart.
I'd like to give users the option of:
- Use the default configmap
- Provide your own existing configmap to replace the default
@SarjakSShah is effectively suggesting we instead add an append option, which I'm not against, but I'm worried will bring me more work to resolve in the future when people expect existing config options to be replaced / duplicates start appearing and I have to offer option 2 anyway to resolve those kinds of issues.
from charts.
Well, the nice thing about redis.config.* settings is that you can easily override a setting in a secondary values.yaml. We now use it to override the maxmemory setting for the production environment. Like this:
redis:
config:
maxmemory: "12gb"
The drawback of redis.customConfig seems that is overrules the redis.config.* settings and you have to copy all config if you want to override just one.
Or is there another way to have a default redis config and override the maxmemory if necessary?
from charts.
Closing for housekeeping as there's not a lot of movement on this right now. I'm happy to discuss this further if the conversation still needs to happen.
from charts.
Related Issues (20)
- [chart/redis-ha][BUG] check_if_redis_is_master backend fails tcp-check on QUIT command
- [chart/redis-ha][redis-ha-configmap Test image variable]
- [chart/redis-ha][REQUEST] use fullname template in test container name HOT 1
- [chart/redis-ha] split-brain-fix.sh is executed on "sh" but uses "==" instead of "=" for comparison HOT 2
- [chart/grafana-agent>][override max_bytes_per_trace] HOT 1
- Allow setting annotations on Pods in StatefulSet HOT 2
- sysctl init container doesn"t have privileges HOT 7
- [chart/redis-ha][Make redis service actually have a ClusterIP address, not to be headless always] HOT 5
- [chart/redis-ha][REQUEST] Allow setting custom readiness and liveness checks to workaround unexpected issues in Redis
- [chart/redis-ha][REQUEST] HOT 1
- [chart/redis-ha][REQUEST] change default image tag for haproxy to alpine build image HOT 1
- [chart/redis-ha][BUG] Can only do a rolling update of the ha-proxy deployment on a cluster with min 4 nodes HOT 4
- [chart/redis-ha][BUG] redhat w/ ulimit unlimited max out cpu & memory, could we add to helm chart a default maxconn? HOT 2
- [chart/redis-ha]support configuration for redis container command parameter HOT 2
- [chart/redis-ha] allow creation of network policies for haproxy HOT 3
- [chart/redis-ha][REQUEST] HOT 1
- [chart/redis-ha][BUG] podDisruptionBudget api-version detection does not work HOT 1
- Publish Action failing [BUG] HOT 2
- [charts/redis-ha] HOT 1
- [chart/redis-ha][service to expose the read only replicas] HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from charts.