Coder Social home page Coder Social logo

Comments (5)

DandyDeveloper avatar DandyDeveloper commented on May 17, 2024

I've added some comments in your PR to confirm some things. Get back to me when you can!

from charts.

fveerden avatar fveerden commented on May 17, 2024

When will this be merged, as it is now impossible to add more than one SAVE instruction in the redis.config

from charts.

DandyDeveloper avatar DandyDeveloper commented on May 17, 2024

@fveerden Sorry, I completely missed @SarjakSShah response to my original suggestions.

Right now, I'm torn between what options we offer here without bringing more unnecessary complexity into the chart.

I'd like to give users the option of:

  1. Use the default configmap
  2. Provide your own existing configmap to replace the default

@SarjakSShah is effectively suggesting we instead add an append option, which I'm not against, but I'm worried will bring me more work to resolve in the future when people expect existing config options to be replaced / duplicates start appearing and I have to offer option 2 anyway to resolve those kinds of issues.

from charts.

fveerden avatar fveerden commented on May 17, 2024

Well, the nice thing about redis.config.* settings is that you can easily override a setting in a secondary values.yaml. We now use it to override the maxmemory setting for the production environment. Like this:

redis:
  config:
    maxmemory: "12gb"

The drawback of redis.customConfig seems that is overrules the redis.config.* settings and you have to copy all config if you want to override just one.
Or is there another way to have a default redis config and override the maxmemory if necessary?

from charts.

DandyDeveloper avatar DandyDeveloper commented on May 17, 2024

Closing for housekeeping as there's not a lot of movement on this right now. I'm happy to discuss this further if the conversation still needs to happen.

from charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.