Comments (5)
Hi Jonas,
Thanks for the offer to help; PRs would be appreciated.
As for where exactly to contribute the code, I hope that @mkozhukh will help unify the repositories. Right now we have three repos:
- https://github.com/dandv/meteor-webix - the Meteor wrapper package. Uses webix and a fork of webix-meteor-data.
- https://github.com/dandv/webix-meteor-data - fork of the Meteor proxy (until the Webix team accepts the PRs). Used by the package.
- https://github.com/webix-hub/webix-meteor-example with a standalone example that doesn't use the package but provides extra Meteor integration (the Blaze template rendering)
My suggestions:
- Seems best to have a single repository as the source for the integration, and it seems easiest to merge the Meteor integration code from webix-meteor-example into webix-meteor-data, or even better, directly into this repo, https://github.com/dandv/meteor-webix, because it does packaging according to the Meteor standard. I've already added @mkozhukh as a contributor to this repo, and I'm happy to transfer it into the webix-hub organization. Also, this repo got quite popular (220+ stars, almost 100 watchers - much more popular than Webix itself!) so we should use that to attract more contributors.
- That will eliminate the need for https://github.com/dandv/meteor-webix to include https://github.com/webix-hub/webix-meteor-data as a submodule, so the latter repository can be deleted/deprecated and instead we can have just one webix-meteor adapter
.js
file, with the proxy (now in webix-meteor-data) and Blaze template rendering (now in webix-meteor-example). - This repo already has an example, so we can merge any extra example code from webix-meteor-example into it as well.
@mkozhukh, what do you think?
from meteor-webix.
I think the pro version of Webix has more features and the additional components (pivot table etc.). I'm not sure if the additional features are stripped out from the webix-hub/tracker repository.
So I would suggest to have a separate Webix wrapper package and one or more additional Webix Meteor integration packages that depend on the Webix wrapper package.
Users of the pro version could clone this wrapper package as local package and replace the webix files with the pro version.
I've done this structure for the current project I work on already:
@mkozhukh Is the https://github.com/webix-hub/webix-meteor-example also under MIT license? The license is missing right now.
from meteor-webix.
@sanjo: good point re. the Pro version. This repo is indeed structured to include Webix and the adapter as two submodules, and a Pro user could overwrite webix_debug.js
in the webix submodule with the Pro version.
If the webix-meteor proxy adapter needs any extra code for the Pro widgets, that code could still go in the same adapter file, since it will be relatively very small by comparison to the size of the library itself (unless the adapter code somehow needs any part of the Pro version to be already instantiated, which I doubt is the case).
In any case, we can at least unify webix-meteor-data and webix-meteor-example, since the latter includes everything in the former, and fixes the example.
from meteor-webix.
Seems best to have a single repository as the source for the integration
I'm agree about merging webix-meteor-data and webix-meteor-example in this repo.
Is the https://github.com/webix-hub/webix-meteor-example also under MIT license
Yes. All projects except of main Webix repo are under MIT license. I will update readme files to make it clear.
If the webix-meteor proxy adapter needs any extra code for the Pro widgets
While PRO version has some extra widgets it uses the same code for data loading as GPL version. There will be no need for PRO-related modifications in data-adapter.
from meteor-webix.
About "routing with Webix layout"
As far as I can see there are two possible solution:
- "Meteor first" app. In such app main UI is created through Meteor templates. Webix UI is created through templates as well. Updated sample ( https://github.com/webix-hub/webix-meteor-example ) uses this approach. The major disadvantage here that you need to have HTML placeholder for each Webix UI block that seriously limit Webix layout auto-sizing ability.
- "Webix first" app. I have published example at https://github.com/webix-hub/webix-meteor-mvc. This is a port of mvc layer from webix-adminapp-demo. Instead of using Meteor templates it uses Webix views as main building block. ( you still can use Meteor templates inside of webix views ) Such approach allows to fully utilize the functionality of Webix Layout, but it is quite different from common Meteor app.
from meteor-webix.
Related Issues (20)
- Meteor style example HOT 1
- Demo site not working anymore HOT 1
- Error callback for collection operations
- Scrolling stops on mobiles and tablets straight after installing meteor webix HOT 2
- Update to 2.4.7 HOT 4
- Sort? HOT 1
- Editing a property of a JSON object (i.e. Mongo Document) HOT 6
- Vertical resizer breaks the crud example
- Publish/Subscribe Large collections HOT 1
- Is this amazing project going to restart sometime soon? HOT 17
- Preserve sort order when items are added to the Datatable
- Google Map to a webix template-driven widget
- Package version of webix:webix is wrong? HOT 4
- Bad link in readme.md
- Meteor UserAccounts Webix project started HOT 4
- Meteor Webix UserAccounts (v1.0.0) HOT 6
- Webix Form half-works HOT 1
- Missing Webix.css
- Font Awesome version mismatch
- Any way to update to webix 3.1? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meteor-webix.