Coder Social home page Coder Social logo

Comments (4)

dancryer avatar dancryer commented on May 20, 2024

Fixed in master, you'll need to run a composer update to pull the updated b8framework too.

from phpci.

MarkMaldaba avatar MarkMaldaba commented on May 20, 2024

Hi there,

I've done a composer update, and am now on block8/b8framework dev-master, commit d6649972547c3a4085dea44bbd6405025972187e. However this still has a number of instances of the <?= tag. Am I on the wrong revision, or have you missed some?

Here's the output of grep "<?=" -r . in the vendor/block8 folder.

./b8framework/b8/Form/View/Button.phtml:<input class="btn <?= $css; ?>" type="<?= $type; ?>" value="<?= $value; ?>">
./b8framework/b8/Form/View/Checkbox.phtml:<div class="control-group <?= $ccss ?> <?= (isset($error) ? 'error' : ''); ?>">
./b8framework/b8/Form/View/Checkbox.phtml:              <label class="checkbox <?= $css; ?>" for="<?= $id ?>">
./b8framework/b8/Form/View/Checkbox.phtml:                      <input type="checkbox" id="<?= $id; ?>" name="<?= $name; ?>" value="<?= $checkedValue; ?>" <?= ($checked ? 'checked' : ''); ?> <?= $required ? 'required' : '' ?>>
./b8framework/b8/Form/View/Checkbox.phtml:                      <?= $label; ?>
./b8framework/b8/Form/View/Checkbox.phtml:                      <span class="help-block"><?= $error; ?></span>
./b8framework/b8/Form/View/CheckboxGroup.phtml:<div class="control-group <?= $css; ?>">
./b8framework/b8/Form/View/CheckboxGroup.phtml:         <label class="control-label"><?= $label; ?></label>
./b8framework/b8/Form/View/CheckboxGroup.phtml:                 <?= $field; ?>
./b8framework/b8/Form/View/ControlGroup.phtml:<div class="control-group <?= $css; ?>">
./b8framework/b8/Form/View/ControlGroup.phtml:          <?= $field; ?>
./b8framework/b8/Form/View/Csrf.phtml:<input type="hidden" id="<?= $id; ?>" name="<?= $name; ?>" value="<?= $csrf; ?>">
./b8framework/b8/Form/View/FieldSet.phtml:<fieldset class="row <?= $css; ?>">
./b8framework/b8/Form/View/FieldSet.phtml:      <legend><?= $label; ?></legend>
./b8framework/b8/Form/View/FieldSet.phtml:              <?= $field; ?>
./b8framework/b8/Form/View/Form.phtml:<form id="<?= $id; ?>" class="<?= $css; ?>" action="<?= $action; ?>" method="<?= $method; ?>">
./b8framework/b8/Form/View/Form.phtml:  <?= $field; ?>
./b8framework/b8/Form/View/Hidden.phtml:<input type="hidden" id="<?= $id; ?>" name="<?= $name; ?>" value="<?= $value; ?>">
./b8framework/b8/Form/View/Radio.phtml:<div id="<?= $id; ?>" class="control-group <?= $ccss; ?>">
./b8framework/b8/Form/View/Radio.phtml:         <label class="control-label"><?= $label; ?></label>
./b8framework/b8/Form/View/Radio.phtml: <label class="radio" for="radio-<?= $id; ?>-<?= $val; ?>">
./b8framework/b8/Form/View/Radio.phtml:         <input type="radio" id="radio-<?= $id; ?>-<?= $val; ?>" class="<?= $css; ?>" name="<?= $name; ?>" value="<?= $val; ?>" <?= ($value == $val) ? ' checked="checked"' : ''; ?> <?= $required ? 'required' : '' ?>>
./b8framework/b8/Form/View/Radio.phtml:         <?= $lbl; ?>
./b8framework/b8/Form/View/Radio.phtml:                 <span class="help-block"><?= $error; ?></span>
./b8framework/b8/Form/View/Select.phtml:<div class="control-group <?= $ccss; ?>">
./b8framework/b8/Form/View/Select.phtml:                <label class="control-label" for="<?= $id ?>"><?= $label; ?></label>
./b8framework/b8/Form/View/Select.phtml:        <select id="<?= $id; ?>" class="<?= $css; ?>" name="<?= $name; ?>">
./b8framework/b8/Form/View/Select.phtml:                <option value="<?= $val; ?>" <?= ($value == $val) ? ' selected="selected"' : ''; ?>><?= $lbl; ?></option>
./b8framework/b8/Form/View/Select.phtml:                        <span class="help-block"><?= $error; ?></span>
./b8framework/b8/Form/View/Text.phtml:<div class="control-group <?= $ccss; ?> <?= (isset($error) ? 'error' : ''); ?>">
./b8framework/b8/Form/View/Text.phtml:  <label class="control-label" for="<?= $id ?>"><?= $label; ?></label>
./b8framework/b8/Form/View/Text.phtml:          <input id="<?= $id; ?>" type="<?= $type; ?>" class="<?= $css; ?>" name="<?= $name; ?>" <?= isset($value) ? ' value="' . $value . '"' : '' ?> <?= isset($pattern) ? ' pattern="' . $pattern . '"' : '' ?> <?= $required ? ' required' : '' ?>>
./b8framework/b8/Form/View/Text.phtml:          <span class="help-block"><?= $error; ?></span>
./b8framework/b8/Form/View/TextArea.phtml:<div class="control-group <?= $ccss; ?> <?= (isset($error) ? 'error' : ''); ?>">
./b8framework/b8/Form/View/TextArea.phtml:              <label class="control-label" for="<?= $id ?>"><?= $label; ?></label>
./b8framework/b8/Form/View/TextArea.phtml:              <textarea rows="<?= $rows; ?>" id="<?= $id; ?>" class="<?= $css; ?>" name="<?= $name; ?>" <?= $required? ' required' : '' ?>><?= isset($value) ? $value : '' ?></textarea>
./b8framework/b8/Form/View/TextArea.phtml:                      <span class="help-block"><?= $error; ?></span>

from phpci.

dancryer avatar dancryer commented on May 20, 2024

I may have pushed the wrong changeset to the b8framework repo last night. Try do another Composer update in a couple of minutes (let Packagist pick it up) and you should be all set.

from phpci.

MarkMaldaba avatar MarkMaldaba commented on May 20, 2024

Great - that's done the trick. Thanks Dan.

from phpci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.