Support for Symfony 6 + DBAL3 (tests), and PHP 8.1 support about auditor

[DamienHarper]

@yivi Thanks for trying to bring sf6 compat to this lib, much appreciated 👍🏽
Here is my point on your first questions:

Would it be worth attempting to fix these issues on branch 1.x, and have support from Sf 3 to Sf 6 on this branch... or would this efforts better directed at the v2 Branch?

As I mentioned in the README.md on master branch (which is the v2 branch), v2 drops support of sf3.4 and PHP 7.2 (still thinking about dropping PHP 7.3 support as well as it is not supported anymore for quite a long time now).
1.x branch will only receive critical and/or security fixes so using master branch (v2) it is the way to go.

Do you consider v2 branch to be near enough to be released in the near future?

I hope so, I'd like to release v2 sometime in late January or February (no fixed date though).

Regarding external tools such as PHPStan and PHP-CS-Fixer, I know they become a blocker and should not belong to real dev dependencies so we have to find a way to workaround this. Right now, I do not have a preferred way of doing this but having them installed in a dedicated composer.json file (and dedicated bin folder) seems a good start.

Best wishes for this new year!

Edit:

• doctrine/doctrine-migrations-bundle is not a dependency anymore with v2 (master branch)
• doctrine/dbal v3 is not a problem anymore with v2 (master branch)

[yivi]

Great! Are there any tasks with which one could help? Any "help-wanted-accepted" issues where a PR would be welcome on the master branch?

[DamienHarper]

@yivi I haven't tested sf6 compatibility, any help on this would be much appreciated :)

[yivi]

After setting the the symfony/* deps to ^6.0 and updating, all tests run fine without issue. I'll make more checks on the "bundle" package later.

What PHP version are you targeting for this release? On the readme it says >= 7.4, but I've seen a couple mixed return type-hint that would break on PHP < 8 (twice in AuditTrait, and twice in RangeFilter). Is that correct?

I'm fine with >= 8 if that's the case.

On another note, great thing moving the tools to tools. I would personally include the lock-files for each tool as well, so anyone testing the tool would use the exact same version of the tool than you or CI.

[DamienHarper]

@yivi

After setting the the symfony/* deps to ^6.0 and updating, all tests run fine without issue. I'll make more checks on the "bundle" package later.

Great, thanks!

What PHP version are you targeting for this release? On the readme it says >= 7.4, but I've seen a couple mixed return type-hint that would break on PHP < 8 (twice in AuditTrait, and twice in RangeFilter). Is that correct?

I'm fine with >= 8 if that's the case.

As mentioned in the README.md I target PHP >= 7.4 so those mixed returns should be removed, you're right.

On another note, great thing moving the tools to tools. I would personally include the lock-files for each tool as well, so anyone testing the tool would use the exact same version of the tool than you or CI.

Yeah, this has to be done too ;)