authorizedCallback called before wellknown endpoint is discovered about angular-auth-oidc-client

[bluebaroncanada]

Updated link https://github.com/damienbod/AspNet5IdentityServerAngularImplicitFlow/blob/master/src/AngularClientIdTokenOnly/angularApp/app/app.component.ts

[damienbod]

thanks for this.

[craigpayne]

Experiencing the same problem. Has this been fixed? Authorize firing before discovery endpoint loaded

[damienbod]

@craigpayne no, plan to do this as soon as I have access to a PC, in 2 weeks

[damienbod]

You could also subscribe to the onModuleSetup event before calling the authorize or authorizeCallback functions see the api docs for an example

[damienbod]

@Silthus @craigpayne Is the following solution ok for you?

subscribe to the onModuleSetup event:

 constructor(public oidcSecurityService: OidcSecurityService) {
        this.oidcSecurityService.onModuleSetup.subscribe(() => { this.onModuleSetup(); });
    }

handle the authorize callback using the event:

 private onModuleSetup() {
        if (window.location.hash) {
            this.oidcSecurityService.authorizedCallback();
        }
    }

unsubscribe

 ngOnDestroy(): void {
        this.oidcSecurityService.onModuleSetup.unsubscribe();
    }

[Silthus]

Looks great 👍🏻

…

On Wed 9. Aug 2017 at 19:42, damienbod ***@***.***> wrote: @Silthus <https://github.com/silthus> @craigpayne <https://github.com/craigpayne> Is the following solution ok for you: subscribe to the onModuleSetup event: constructor(public oidcSecurityService: OidcSecurityService) { this.oidcSecurityService.onModuleSetup.subscribe(() => { this.onModuleSetup(); }); } Handle the authorize callback using the event: private onModuleSetup() { if (window.location.hash) { this.oidcSecurityService.authorizedCallback(); } } unsubscribe ngOnDestroy(): void { this.oidcSecurityService.onModuleSetup.unsubscribe(); } — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#50 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAuGfz_UeHgdIBaA1ueAswPC-dRgceSkks5sWe-JgaJpZM4Ohnq0> .

[damienbod]

just testing, this doesn't always work because the onModuleSetup event is sometimes before the component subscribes to it. Need to add a moduleSetup boolean check.

        if (this.oidcSecurityService.moduleSetup) {
            this.doCallbackLogicIfRequired();
        } else {
            this.oidcSecurityService.onModuleSetup.subscribe(() => {
                this.doCallbackLogicIfRequired();
            });
        }

[damienbod]

fixed in version 1.3.3
Example:
https://github.com/damienbod/angular-auth-oidc-sample-google-openid/blob/master/src/AngularClient/angularApp/app/app.component.ts