Comments (8)
I agree - but unfortunately I'm extremely pushed for time and as you can probably tell I haven't made any improvements in the last 9 months - which coincides directly with the birth of my baby girl.
If you have the time and are willing please feel free to make any improvements you think necessary and send me a pull request.
Sent from my iPad
On 29 Jan 2014, at 20:47, anoordover [email protected] wrote:
I think that the class ReportBuilder does to much.
It prepares variables for the reports.
It starts the merging with a Freemarker template.
It writes the result to a file.
I think writing tests for this class is therefore to hard.
Should we use mockito to do the unittest?
How can we enhance testability?
Instantiation of classes is much harder to mock.
Should we use use powermockito or use factories which can be injected for mocking purposes?—
Reply to this email directly or view it on GitHub.
from cucumber-reporting.
I would like to make choices you can support as well. So can you make a
choice about the strategy to follow.
So:
- Mockito with powermockito;
- EasyMock
- Implement a method for setting factory so mockito can be used without
powermockito - Another strategy
Gr Arno
Btw i have send you a pull request for the template change. Can you take a
look?
Op 29 jan. 2014 21:57 schreef "Kingsley Hendrickse" <
[email protected]>:
I agree - but unfortunately I'm extremely pushed for time and as you can
probably tell I haven't made any improvements in the last 9 months - which
coincides directly with the birth of my baby girl.If you have the time and are willing please feel free to make any
improvements you think necessary and send me a pull request.Sent from my iPad
On 29 Jan 2014, at 20:47, anoordover [email protected] wrote:
I think that the class ReportBuilder does to much.
It prepares variables for the reports.
It starts the merging with a Freemarker template.
It writes the result to a file.
I think writing tests for this class is therefore to hard.
Should we use mockito to do the unittest?
How can we enhance testability?
Instantiation of classes is much harder to mock.
Should we use use powermockito or use factories which can be injected
for mocking purposes?Reply to this email directly or view it on GitHub.
Reply to this email directly or view it on GitHubhttps://github.com//issues/51#issuecomment-33629769
.
from cucumber-reporting.
Hi
In the long term I'd like to move to java 8 and take a more functional style.
I'm sure significant improvement could be made with totally lazy.
But as per your question - I have no strong preference - feel free to make a choice.
Sent from my iPhone
On 29 Jan 2014, at 21:05, anoordover [email protected] wrote:
I would like to make choices you can support as well. So can you make a
choice about the strategy to follow.
So:
- Mockito with powermockito;
- EasyMock
- Implement a method for setting factory so mockito can be used without
powermockito- Another strategy
Gr Arno
Btw i have send you a pull request for the template change. Can you take a
look?
Op 29 jan. 2014 21:57 schreef "Kingsley Hendrickse" <
[email protected]>:I agree - but unfortunately I'm extremely pushed for time and as you can
probably tell I haven't made any improvements in the last 9 months - which
coincides directly with the birth of my baby girl.If you have the time and are willing please feel free to make any
improvements you think necessary and send me a pull request.Sent from my iPad
On 29 Jan 2014, at 20:47, anoordover [email protected] wrote:
I think that the class ReportBuilder does to much.
It prepares variables for the reports.
It starts the merging with a Freemarker template.
It writes the result to a file.
I think writing tests for this class is therefore to hard.
Should we use mockito to do the unittest?
How can we enhance testability?
Instantiation of classes is much harder to mock.
Should we use use powermockito or use factories which can be injected
for mocking purposes?Reply to this email directly or view it on GitHub.
Reply to this email directly or view it on GitHubhttps://github.com//issues/51#issuecomment-33629769
.—
Reply to this email directly or view it on GitHub.
from cucumber-reporting.
Is she your first? Your baby girl?
Op 29 jan. 2014 21:57 schreef "Kingsley Hendrickse" <
[email protected]>:
I agree - but unfortunately I'm extremely pushed for time and as you can
probably tell I haven't made any improvements in the last 9 months - which
coincides directly with the birth of my baby girl.If you have the time and are willing please feel free to make any
improvements you think necessary and send me a pull request.Sent from my iPad
On 29 Jan 2014, at 20:47, anoordover [email protected] wrote:
I think that the class ReportBuilder does to much.
It prepares variables for the reports.
It starts the merging with a Freemarker template.
It writes the result to a file.
I think writing tests for this class is therefore to hard.
Should we use mockito to do the unittest?
How can we enhance testability?
Instantiation of classes is much harder to mock.
Should we use use powermockito or use factories which can be injected
for mocking purposes?Reply to this email directly or view it on GitHub.
Reply to this email directly or view it on GitHubhttps://github.com//issues/51#issuecomment-33629769
.
from cucumber-reporting.
Yep !!
Sent from my iPhone
On 29 Jan 2014, at 21:19, anoordover [email protected] wrote:
Is she your first? Your baby girl?
Op 29 jan. 2014 21:57 schreef "Kingsley Hendrickse" <
[email protected]>:I agree - but unfortunately I'm extremely pushed for time and as you can
probably tell I haven't made any improvements in the last 9 months - which
coincides directly with the birth of my baby girl.If you have the time and are willing please feel free to make any
improvements you think necessary and send me a pull request.Sent from my iPad
On 29 Jan 2014, at 20:47, anoordover [email protected] wrote:
I think that the class ReportBuilder does to much.
It prepares variables for the reports.
It starts the merging with a Freemarker template.
It writes the result to a file.
I think writing tests for this class is therefore to hard.
Should we use mockito to do the unittest?
How can we enhance testability?
Instantiation of classes is much harder to mock.
Should we use use powermockito or use factories which can be injected
for mocking purposes?Reply to this email directly or view it on GitHub.
Reply to this email directly or view it on GitHubhttps://github.com//issues/51#issuecomment-33629769
.—
Reply to this email directly or view it on GitHub.
from cucumber-reporting.
Nice photo on facebook?!
Kingsley Hendrickse [email protected]:
Yep !!
Sent from my iPhone
On 29 Jan 2014, at 21:19, anoordover [email protected] wrote:
Is she your first? Your baby girl?
Op 29 jan. 2014 21:57 schreef "Kingsley Hendrickse" <
[email protected]>:I agree - but unfortunately I'm extremely pushed for time and as you can
probably tell I haven't made any improvements in the last 9 months - which
coincides directly with the birth of my baby girl.If you have the time and are willing please feel free to make any
improvements you think necessary and send me a pull request.Sent from my iPad
On 29 Jan 2014, at 20:47, anoordover [email protected] wrote:
I think that the class ReportBuilder does to much.
It prepares variables for the reports.
It starts the merging with a Freemarker template.
It writes the result to a file.
I think writing tests for this class is therefore to hard.
Should we use mockito to do the unittest?
How can we enhance testability?
Instantiation of classes is much harder to mock.
Should we use use powermockito or use factories which can be injected
for mocking purposes?Reply to this email directly or view it on GitHub.
Reply to this email directly or view it on GitHubhttps://github.com//issues/51#issuecomment-33629769
.—
Reply to this email directly or view it on GitHub.
Reply to this email directly or view it on GitHub:
#51 (comment)
from cucumber-reporting.
Thumbs up for Mockito with powermockito.
And how about using Cucumber for testing?
from cucumber-reporting.
Have been improved and will be even better in version 1.x.x
from cucumber-reporting.
Related Issues (20)
- Build Execution Date on horizontal axis HOT 3
- Error: Action failed with "The process '/usr/bin/git' failed with exit code 1" HOT 1
- Cucumber fails build report with 0 tests HOT 1
- Qualifier missing from the report-feature html HOT 1
- Not able to log in cucumber-reporting HOT 1
- Failed to parse plugin descriptor for net.masterthought:cucumber-reporting:5.7.6 HOT 1
- Generate Cucumber Report with Tags Excluded HOT 1
- Reporting url changed HOT 3
- Maven cucumber reporting stopped working on update to Selenium 4.14.1 from Selenium 4.13.0 HOT 2
- How to add execution duration at scenario level in cucumber reports HOT 3
- JSON File Limit HOT 1
- Cucumber html report screen is blur and couldn't able to access the report HOT 1
- Update Qualifiers in reports when cucumber json output has information on OS and devices HOT 9
- Karate framework cannot deserialize cucumber json.feature file
- How to customize json report generated by cucumber to feed it to this cucumber-reporting tool HOT 3
- How to merge 2 json files into one html report HOT 2
- Any Options to Disabled of Hide Animations on Dashboard Screen ?
- LICENSE error reported by Snyk scan HOT 2
- Is it possible to not create html file for each tag on the project? HOT 1
- Not able to generate a cucumber report when embed image is long HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cucumber-reporting.