ReportBuilder feature envy about cucumber-reporting

[kingsleyh]

I agree - but unfortunately I'm extremely pushed for time and as you can probably tell I haven't made any improvements in the last 9 months - which coincides directly with the birth of my baby girl.

If you have the time and are willing please feel free to make any improvements you think necessary and send me a pull request.

Sent from my iPad

On 29 Jan 2014, at 20:47, anoordover [email protected] wrote:

I think that the class ReportBuilder does to much.
It prepares variables for the reports.
It starts the merging with a Freemarker template.
It writes the result to a file.
I think writing tests for this class is therefore to hard.
Should we use mockito to do the unittest?
How can we enhance testability?
Instantiation of classes is much harder to mock.
Should we use use powermockito or use factories which can be injected for mocking purposes?

—
Reply to this email directly or view it on GitHub.

[anoordover]

I would like to make choices you can support as well. So can you make a
choice about the strategy to follow.
So:

1. Mockito with powermockito;
2. EasyMock
3. Implement a method for setting factory so mockito can be used without
   powermockito
4. Another strategy

Gr Arno

Btw i have send you a pull request for the template change. Can you take a
look?
Op 29 jan. 2014 21:57 schreef "Kingsley Hendrickse" <
[email protected]>:

I agree - but unfortunately I'm extremely pushed for time and as you can
probably tell I haven't made any improvements in the last 9 months - which
coincides directly with the birth of my baby girl.

If you have the time and are willing please feel free to make any
improvements you think necessary and send me a pull request.

Sent from my iPad

On 29 Jan 2014, at 20:47, anoordover [email protected] wrote:

I think that the class ReportBuilder does to much.
It prepares variables for the reports.
It starts the merging with a Freemarker template.
It writes the result to a file.
I think writing tests for this class is therefore to hard.
Should we use mockito to do the unittest?
How can we enhance testability?
Instantiation of classes is much harder to mock.
Should we use use powermockito or use factories which can be injected
for mocking purposes?

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com//issues/51#issuecomment-33629769
.

[kingsleyh]

Hi

In the long term I'd like to move to java 8 and take a more functional style.

I'm sure significant improvement could be made with totally lazy.

But as per your question - I have no strong preference - feel free to make a choice.

Sent from my iPhone

On 29 Jan 2014, at 21:05, anoordover [email protected] wrote:

I would like to make choices you can support as well. So can you make a
choice about the strategy to follow.
So:

1. Mockito with powermockito;
2. EasyMock
3. Implement a method for setting factory so mockito can be used without
   powermockito
4. Another strategy

Gr Arno

Btw i have send you a pull request for the template change. Can you take a
look?
Op 29 jan. 2014 21:57 schreef "Kingsley Hendrickse" <
[email protected]>:

I agree - but unfortunately I'm extremely pushed for time and as you can
probably tell I haven't made any improvements in the last 9 months - which
coincides directly with the birth of my baby girl.

If you have the time and are willing please feel free to make any
improvements you think necessary and send me a pull request.

Sent from my iPad

On 29 Jan 2014, at 20:47, anoordover [email protected] wrote:

I think that the class ReportBuilder does to much.
It prepares variables for the reports.
It starts the merging with a Freemarker template.
It writes the result to a file.
I think writing tests for this class is therefore to hard.
Should we use mockito to do the unittest?
How can we enhance testability?
Instantiation of classes is much harder to mock.
Should we use use powermockito or use factories which can be injected
for mocking purposes?

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com//issues/51#issuecomment-33629769
.

—
Reply to this email directly or view it on GitHub.

[anoordover]

Is she your first? Your baby girl?
Op 29 jan. 2014 21:57 schreef "Kingsley Hendrickse" <
[email protected]>:

I agree - but unfortunately I'm extremely pushed for time and as you can
probably tell I haven't made any improvements in the last 9 months - which
coincides directly with the birth of my baby girl.

If you have the time and are willing please feel free to make any
improvements you think necessary and send me a pull request.

Sent from my iPad

On 29 Jan 2014, at 20:47, anoordover [email protected] wrote:

I think that the class ReportBuilder does to much.
It prepares variables for the reports.
It starts the merging with a Freemarker template.
It writes the result to a file.
I think writing tests for this class is therefore to hard.
Should we use mockito to do the unittest?
How can we enhance testability?
Instantiation of classes is much harder to mock.
Should we use use powermockito or use factories which can be injected
for mocking purposes?

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com//issues/51#issuecomment-33629769
.

[kingsleyh]

Yep !!

Sent from my iPhone

On 29 Jan 2014, at 21:19, anoordover [email protected] wrote:

Is she your first? Your baby girl?
Op 29 jan. 2014 21:57 schreef "Kingsley Hendrickse" <
[email protected]>:

I agree - but unfortunately I'm extremely pushed for time and as you can
probably tell I haven't made any improvements in the last 9 months - which
coincides directly with the birth of my baby girl.

If you have the time and are willing please feel free to make any
improvements you think necessary and send me a pull request.

Sent from my iPad

On 29 Jan 2014, at 20:47, anoordover [email protected] wrote:

I think that the class ReportBuilder does to much.
It prepares variables for the reports.
It starts the merging with a Freemarker template.
It writes the result to a file.
I think writing tests for this class is therefore to hard.
Should we use mockito to do the unittest?
How can we enhance testability?
Instantiation of classes is much harder to mock.
Should we use use powermockito or use factories which can be injected
for mocking purposes?

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com//issues/51#issuecomment-33629769
.

—
Reply to this email directly or view it on GitHub.

[anoordover]

Nice photo on facebook?!

Kingsley Hendrickse [email protected]:

Yep !!

Sent from my iPhone

On 29 Jan 2014, at 21:19, anoordover [email protected] wrote:

Is she your first? Your baby girl?
Op 29 jan. 2014 21:57 schreef "Kingsley Hendrickse" <
[email protected]>:

I agree - but unfortunately I'm extremely pushed for time and as you can
probably tell I haven't made any improvements in the last 9 months - which
coincides directly with the birth of my baby girl.

If you have the time and are willing please feel free to make any
improvements you think necessary and send me a pull request.

Sent from my iPad

On 29 Jan 2014, at 20:47, anoordover [email protected] wrote:

I think that the class ReportBuilder does to much.
It prepares variables for the reports.
It starts the merging with a Freemarker template.
It writes the result to a file.
I think writing tests for this class is therefore to hard.
Should we use mockito to do the unittest?
How can we enhance testability?
Instantiation of classes is much harder to mock.
Should we use use powermockito or use factories which can be injected
for mocking purposes?

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com//issues/51#issuecomment-33629769
.

—
Reply to this email directly or view it on GitHub.

---

Reply to this email directly or view it on GitHub:
#51 (comment)

[btaz]

Thumbs up for Mockito with powermockito.
And how about using Cucumber for testing?

[damianszczepanik]

Have been improved and will be even better in version 1.x.x