Coder Social home page Coder Social logo

Comments (11)

DamascenoRafael avatar DamascenoRafael commented on August 20, 2024 2

@pie6k, @chriswmartin , @alicerunsonfedora, @twenrut
New release v1.6.0 should resolve this issue. Sorry for taking so long.
Please let me know if something doesn't work as expected.

from reminders-menubar.

pie6k avatar pie6k commented on August 20, 2024 1

Ok, I tried your code changes.

I did build it natively (M1 mac) and it did not run (with error 'could not attach to process PID: ').

Then I tried Rosetta build and it worked and built, but then crashed:

extension NSTextField {
    open override var focusRingType: NSFocusRingType {
        get { .none }
        set { self.focusRingType = newValue } // <—- error here `Thread 1: EXC_BAD_ACCESS (code=2, address=0x304989ff8)`
    }
}

CleanShot 2021-09-20 at 17 02 22@2x

[update]

After also commenting out this extension - it started to work (in Rosetta build, no native M1 build)

from reminders-menubar.

alicerunsonfedora avatar alicerunsonfedora commented on August 20, 2024

I am unsure if there's been an update to address this, but I can confirm that this is still an issue with the latest Monterey dev beta (21A5294g).

from reminders-menubar.

DamascenoRafael avatar DamascenoRafael commented on August 20, 2024

I still can't figure out what causes this error.
In Big Sur, even in Xcode 13 beta there is no problem.
The error would be as if ".environmentObject(remindersData)" was not present.
Maybe creating a SceneDelegate can help, but it still feels weird.

from reminders-menubar.

alicerunsonfedora avatar alicerunsonfedora commented on August 20, 2024

The error would be as if ".environmentObject(remindersData)" was not present.

Is it possible that this method is deprecated in favor of something else? I've never seen this before with SwiftUI.

from reminders-menubar.

twenrut avatar twenrut commented on August 20, 2024

still persists

from reminders-menubar.

alicerunsonfedora avatar alicerunsonfedora commented on August 20, 2024

still persists

I don't believe the issue has been resolved as of yet. I haven't seen a release update to fix this yet.

from reminders-menubar.

DamascenoRafael avatar DamascenoRafael commented on August 20, 2024

Hey, @chriswmartin , @alicerunsonfedora, @twenrut.
Since I'm not using macOS Monterey yet, could one of you run some tests?

  1. In AppDelegate.swift remove the @NSApplicationMain annotation and add @main instead.

  2. If it doesn't work and the error continues: remove the @main annotation from the AppDelegate class and above that declaration add the code below:

    @main
    struct RemindersMenuBar: App {
        @NSApplicationDelegateAdaptor(AppDelegate.self) var appDelegate
        
        var body: some Scene {
            Settings {
                EmptyView()
            }
        }
    }

    In the AppDelegate class make the following changes:

      let popover = NSPopover()
    - let statusBarItem = NSStatusBar.system.statusItem(withLength: NSStatusItem.variableLength)
    + var statusBarItem: NSStatusItem!
      private func configureMenuBarButton() {
    +     statusBarItem = NSStatusBar.system.statusItem(withLength: NSStatusItem.variableLength)
          statusBarItem.button?.image = NSImage(systemSymbolName: "list.bullet", accessibilityDescription: nil)
          statusBarItem.button?.imagePosition = .imageLeading
          statusBarItem.button?.action = #selector(togglePopover)
      }

Please let me know if 1 or 2 fixed the problem or changed the initial error.

from reminders-menubar.

pie6k avatar pie6k commented on August 20, 2024

I am not able to test the code you provided, but it indeed freezes for me as well.

When I open the app - it shows up in menu bar with count number of reminders, but as soon as I click it - it freezes, shows spinner mouse cursor and CPU is at 100%

from reminders-menubar.

DamascenoRafael avatar DamascenoRafael commented on August 20, 2024

Thanks for the help @pie6k.
I just updated to macOS Monterey Beta and I'm verifying it.
This extension has no effect in Monterey but is important in Big Sur.
Removing the set from this property seems to solve the problem.

from reminders-menubar.

DamascenoRafael avatar DamascenoRafael commented on August 20, 2024

Closing this issue since everything seems to be ok :)
New version 1.6.1 fixes another bug on macOS Monterey.

from reminders-menubar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.