Carthage Fails to Build about notificationbanner

[Daltron]

@dsarfati What are the build errors you are receiving specifically? Attach pictures if you are able to as that will tremendously help. I'm unfamiliar with Carthage must maybe my syntax in the README is wrong? Since github "Daltron/NotificationBanner" == 1.3.3 worked, have you tried github "Daltron/NotificationBanner" == 1.4.0? Thanks!

[dsarfati]

I don't have any experience with Carthage either. ==1.4.0 fails as well. Here is the log file from the failed build. I created a sample project here so you can try it out. For other reasons, I have decided to stay with CocoaPods, but I wanted to let you know in case others run into the same problem when using Carthage.

[purkylin]

same issue

[purkylin]

/Users/purkylinking/Work/Repos/Assistant/Carthage/Checkouts/NotificationBanner/NotificationBanner/Classes/BaseNotificationBanner.swift:102:38: error: use of undeclared type 'BannerPosition'
    private(set) var bannerPosition: BannerPosition!
                                     ^~~~~~~~~~~~~~
/Users/purkylinking/Work/Repos/Assistant/Carthage/Checkouts/NotificationBanner/NotificationBanner/Classes/BaseNotificationBanner.swift:105:38: error: use of undeclared type 'BannerPositionFrame'
    private var bannerPositionFrame: BannerPositionFrame!
                                     ^~~~~~~~~~~~~~~~~~~
/Users/purkylinking/Work/Repos/Assistant/Carthage/Checkouts/NotificationBanner/NotificationBanner/Classes/BaseNotificationBanner.swift:155:62: error: use of undeclared type 'BannerPosition'
    private func createBannerConstraints(for bannerPosition: BannerPosition) {
                                                             ^~~~~~~~~~~~~~
/Users/purkylinking/Work/Repos/Assistant/Carthage/Checkouts/NotificationBanner/NotificationBanner/Classes/BaseNotificationBanner.swift:213:38: error: use of undeclared type 'BannerPosition'
                     bannerPosition: BannerPosition = .top,
                                     ^~~~~~~~~~~~~~
/Users/purkylinking/Work/Repos/Assistant/Carthage/Checkouts/NotificationBanner/NotificationBanner/Classes/BaseNotificationBanner.swift:228:31: error: use of undeclared type 'BannerPosition'
              bannerPosition: BannerPosition = .top) {
                              ^~~~~~~~~~~~~~
/Users/purkylinking/Work/Repos/Assistant/Carthage/Checkouts/NotificationBanner/NotificationBanner/Classes/BaseNotificationBanner.swift:233:35: error: use of unresolved identifier 'BannerPositionFrame'
            bannerPositionFrame = BannerPositionFrame(bannerPosition: bannerPosition,
                                  ^~~~~~~~~~~~~~~~~~~
/Users/purkylinking/Work/Repos/Assistant/Carthage/Checkouts/NotificationBanner/NotificationBanner/Classes/BaseNotificationBanner.swift:105:17: note: did you mean 'bannerPositionFrame'?
    private var bannerPositionFrame: BannerPositionFrame!
                ^

CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler

[purkylin]

I found the file BannerPositionFrame.swift is not included in the Project