Coder Social home page Coder Social logo

Comments (4)

dallison avatar dallison commented on May 24, 2024

Did you create a pull request? I will incorporate this into the code (with a naming fix 'name' -> 'name_').

Also, at the moment when you resize a channel, the old buffers are not unmapped when they are no longer in use. I'm going to add a fix for that. There will be a new release soon.

from subspace.

dallison avatar dallison commented on May 24, 2024

I've incorporated this into release 1.1.2. I still need to implement buffer munmap when no references after resize. I'll do that this week.

from subspace.

mikael-s-persson avatar mikael-s-persson commented on May 24, 2024

Cool! Thanks! I couldn't create a pull request due to permission denied. I think you have to add me as a contributor on github if you want me to be able to push new branches, aka pull requests.

About the unmap thing, I noticed that bug too, but I was pretty sure you knew about it already. ;)

from subspace.

dallison avatar dallison commented on May 24, 2024

I've added you as a collaborator. I hadn't noticed the unmap thing until today because I was testing with debug off. It was an easy fix and not really a bug (kind of). Let me know if you see any other bugs. I think it's pretty solid now but there are always more bugs.

from subspace.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.