Coder Social home page Coder Social logo

Comments (6)

sshanzel avatar sshanzel commented on June 15, 2024 1

Hi @idoshamun, I'm terribly sorry it took this long. I didn't realize i haven't had this yet. This was actually my planned contribution for April but i got loaded on my day job with a recent critical project (i had to pour all time my time including weekends on it 😭 all those sleepless nights, but i am totally happy now that it passed all the UAT two days ago 😭). I've created the PR #111 for this, please let me know if you have any concern or issues on it. Thank you very much for understanding!

from daily-apps.

sshanzel avatar sshanzel commented on June 15, 2024

Gonna get started quickly!!! 😁

from daily-apps.

sshanzel avatar sshanzel commented on June 15, 2024

Hi Ido! I just realized, initially we made the keybinding feat centralized so keypress won't trigger 2 events at once, i think this might be contradicting with our first implementation, i've thought that this is much more applicable to be isolated on searchbars only. Since esc might be required to behave differently on different contexts as well. What do you think?

from daily-apps.

idoshamun avatar idoshamun commented on June 15, 2024

I would like to think of esc as the clear temporary filters and go back to home page button. It could be when you selected to see one source/tag, searched for something or even bookmarks. So we have many contexts that might be relevant. What do you think?

from daily-apps.

sshanzel avatar sshanzel commented on June 15, 2024

Totally makes sense! Thank you for the clarification!

from daily-apps.

idoshamun avatar idoshamun commented on June 15, 2024

Hi @sshanzel,
I would like to kindly check the status of this issue :)

from daily-apps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.