Comments (5)
I just see this now. I will ensure we will have a glob
flag upstream in Polars which users can toggle off.
from dagster.
It seems that polars is interpreting square brackets [ ]
as valid shell-glob syntax.
I would recommend that this pattern is not used for DynamicOutput
persistent object paths as it is inevitable that a third party package that uses glob would fail.
This is from the glob man page:
Character classes
An expression "[...]" where the first character after the leading
'[' is not an '!' matches a single character, namely any of the
characters enclosed by the brackets. The string enclosed by the
brackets cannot be empty; therefore ']' can be allowed between
the brackets, provided that it is the first character. (Thus,
"[][!]" matches the three characters '[', ']', and '!'.)
Ranges
There is one special convention: two characters separated by '-'
denote a range. (Thus, "[A-Fa-f0-9]" is equivalent to
"[ABCDEFabcdef0123456789]".) One may include '-' in its literal
meaning by making it the first or last character between the
brackets. (Thus, "[]-]" matches just the two characters ']' and
'-', and "[--0]" matches the three characters '-', '.', and '0',
since '/' cannot be matched.)
https://man7.org/linux/man-pages/man7/glob.7.html
Here is the core bug being tracked in polars
from dagster.
I just see this now. I will ensure we will have a
glob
flag upstream in Polars which users can toggle off.
@ritchie46
Although I agree that a glob
flag would be useful in polars, it seems that in the case of Dagster
, the convention of using square brackets is really the key issue here.
For instance, say an operation created as set out partitioned outputs with the pattern:
output/[partition_A]/[partition_B]/*.parquet
one would like the ability to read all files in lowest folder root.
Perhaps it should be considered invalid syntax to write files containing square brackets and reserve []
to act as correct glob functionality for reads
from dagster.
Compiled and tested against polars master branch. Can confirm the issue has been fixed.
It should be resolved with the latest polars release
from dagster.
Scrap that latest got released two hours ago.
from dagster.
Related Issues (20)
- Make it easier to define freshness checks for dbt models
- ImportError: cannot import name 'GenericAlias' from partially initialized module 'types' HOT 6
- Could not load job definition. dagster._check.CheckError: Invariant failed. Description: No metadata found for CacheableAssetsDefinition with unique_id airbyte / Using I/O Manager BigQuery
- `_get_infer_single_to_multi_dimension_deps_result` is to restrictive, can't handle identityMapped staticPartitionDefintions
- Freshness sensor does not run when assets are pending or failed HOT 1
- Table IO Managers should capture column schemas with appropriate metadata tag HOT 3
- i18n Language Support
- [Documentation Feedback] Problem on /getting-started/quickstart page HOT 1
- docker run launcher not dequeuing runs on dagster 1.7.6 / dagster-docker 0.23.6 HOT 2
- Cannot execute Docker runs HOT 1
- PipesDataBricksClient not accepting a task definition with an existing cluster ID
- CeleryK8sRunLauncher doesn't work with celery_executor HOT 3
- Hooks: slack_on_success and slack_on_failure fail silently to work
- [dagster-deltalake] GcsConfig ImportError and TypeError for partitioned assets
- Different UX when viewing runs locally than in production because of additional tags
- `load_asset_checks_from_module` sometimes returns `AssetsDefinition`s instead of `AssetChecksDefinition`s
- ModuleNotFoundError: No module named 'dbt.adapters.base.impl' HOT 2
- Support tags with colon (:) HOT 1
- Propagate filters when navigating through catalog search results
- dagster_pipes.DagsterPipesError: Cannot send message after pipes context is closed." HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dagster.