Comments (10)
Update, since according to my history I finally have an audience! Will probably try to decide on a name I like this weekend (I'm wondering now if maybe I should just name it nvimg (gnvim is taken), and then create a new repo and move things from my fork over there. Until then, I moved work over to this branch.
from neovim-gtk.
@Lyude eventually it makes sense to enable the issue tracker on your fork, so people can properly address them...
Yeah, was going to say that. I already have an issue to report: Tryint to disable the popup menu (https://github.com/daa84/neovim-gtk/wiki/Configuration#options) with call rpcnotify(1, 'Gui', 'Option', 'Popupmenu', 0)
is not working in your fork.
from neovim-gtk.
... and then create a new repo and move things from my fork over there.
Sorry, why create a new repo? I don't see a problem with showing that the project is a fork, it seems disingenuous to not do that in my opinion.
I mean, for one I have every intent of crediting folks involved (probably on the README.md at the top so it's easily visible when you find the project), crediting folks for their work is important. Regardless though it's not being a fork I have an issue with, moreso as I was under the impression it was more difficult to discover forks of repos then it was original repos? This is just from my memory though, and the vast majority of development I do is outside of Github (usually Gitlab; which I prefer quite a bit for it's code review tools; or mailing lists) so I could be 100% wrong about this. If being a fork doesn't actually make it any harder for people to google "GTK neovim client" and find this project then I'm totally happy to keep it as a fork.
I tested your fork out a bit the other day, though ran into issues with configuration flags not working correctly (to disable popup and tabline). I plan on revisiting at some point and creating some PRs with my own fixes (mostly the outstanding ones in this repo), though I was hoping those flags might be resolved on their own once you finish your ongoing updates.
Yeah that sounds like a blindspot in my testing :)
Thanks again for picking this project up!
no problem! I'm glad to see other folks have interest in this, as I'd definitely like to eventually have more maintainers once more issues start coming in (of course, contributions are welcome at any point! just beware there's still a number of large changes I'm planning on making). Also, I will make sure I've got the issues option on my repo enabled as some folks have pointed out.
from neovim-gtk.
@Lyude eventually it makes sense to enable the issue tracker on your fork, so people can properly address them...
Yeah, was going to say that. I already have an issue to report: Tryint to disable the popup menu (https://github.com/daa84/neovim-gtk/wiki/Configuration#options) with
call rpcnotify(1, 'Gui', 'Option', 'Popupmenu', 0)
is not working in your fork.
@jacobmischka (I forgot to mention you in the commit message whoops) the issue you and @bellini666 reported is fixed in Lyude/neovim-gtk@4e466e3
from neovim-gtk.
Hey @Lyude ,
Nice work there! I'm going to test you fork and use it as my daily driver if it works nice, was always with the impression that this was an "abandoned" project, but it is still the best neovim's UI for me (as someone who came from gvim for vim).
Would be awesome to join forces and merge your fork into here, but maybe the maintainer is not active anymore (considering the latest commit date and lack of replies to issues/PRs, including this one), so we might need to consider your fork the main one for contributions?
Also, would be nice to add it to this list, so it can attract more contributors: https://github.com/rockerBOO/awesome-neovim
from neovim-gtk.
Hey @Lyude ,
Nice work there! I'm going to test you fork and use it as my daily driver if it works nice, was always with the impression that this was an "abandoned" project, but it is still the best neovim's UI for me (as someone who came from gvim for vim).
Would be awesome to join forces and merge your fork into here, but maybe the maintainer is not active anymore (considering the latest commit date and lack of replies to issues/PRs, including this one), so we might need to consider your fork the main one for contributions?
Yep! That's my current plan, I figured I'd give the maintainer a bit of time at least before making the decision final on my end, as it'd be a shame to have to use a different name for this then neovim-gtk. Although I do like the name I'm currently considering going with, hdiq ("how do I quit?")
Also, would be nice to add it to this list, so it can attract more contributors: https://github.com/rockerBOO/awesome-neovim
from neovim-gtk.
Oops, forgot to answer the second question - yeah, I will try to remember to add my project to the awesome-neovim list once I do the name change (probably the next time I sit down to resume work on the gtk+4 conversion)
from neovim-gtk.
Hey @Lyude , awesome!
I already started using your fork, looking forward to new features being added to it! Although I have some good experience with gtk using python, I lack experience with rust... I'll try to help there if I can as neovim-gtk (now on your fork) became my daily driver!
Will at least try to provide some feedback and insights on any issues that I find!
from neovim-gtk.
... and then create a new repo and move things from my fork over there.
Sorry, why create a new repo? I don't see a problem with showing that the project is a fork, it seems disingenuous to not do that in my opinion.
I tested your fork out a bit the other day, though ran into issues with configuration flags not working correctly (to disable popup and tabline). I plan on revisiting at some point and creating some PRs with my own fixes (mostly the outstanding ones in this repo), though I was hoping those flags might be resolved on their own once you finish your ongoing updates.
Thanks again for picking this project up!
from neovim-gtk.
@Lyude eventually it makes sense to enable the issue tracker on your fork, so people can properly address them...
from neovim-gtk.
Related Issues (20)
- argc() not work in vimrc
- Add support to strikethrough text
- Underlines and undercurls are not rendered correctly
- Floating point issues cause gaps in background occasionally
- Characters aren't being drawn sometimes HOT 4
- Characters disappear when NERDTree pane opens HOT 5
- Chinese font width error
- Could not initialize nvim
- Character rendering broken with varying word lengths combined with wrapping HOT 7
- update wiki to include cursor blinking as an option HOT 1
- guisp ignored for underline
- Exits successfully with :cq
- Artifact for Windows not Found HOT 1
- Improvement: Popup menu go below current line
- Impossible to install neovim-gtk on Ubuntu 22.04 (dependency problem with package 'fragile') HOT 2
- NGShowProjectView doesnโt do anything when NVIM_GTK_NO_HEADERBAR=1 HOT 1
- Feature request: open multiple tabs with -p
- Crash when trying to middle-click-paste if clipboard is empty
- Please create a way to send monetary contribution
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from neovim-gtk.