string contains '\n' ,but not quoted about rapidcsv

[d99kris]

Hi @yhviqd - could you please provide some more information about the issue?

Since you mentioned WriteCsv(), is it correct that this an issue faced when writing CSV?

Ideally if you could provide a minimal code snippet that reproduce the issue, along with your expectation and the actual result, it would be very helpful to understand the problem.

Thanks!

[yhviqd]

I have been using this library recently, and my colleague has reported parsing failure, as shown in the following figure

I found that it was due to the inclusion of the enter key and not being enclosed in quotation marks。It should be
”[161][无此功能]
[2103379]
",116
Because the return key is line delimiter, when a string contains it, it should be quoted

[d99kris]

Thanks for providing more details, if I understand the issue correctly you're using rapidcsv::Document::Save() to write CSV data which has cells containing linebreaks. Despite AutoQuote flag being set, the resulting CSV written by rapidcsv contains unquoted cells with linebreak.

I can reproduce the issue and I agree with the proposed fix you mentioned. I will prepare the change and update test(s) accordingly.

[d99kris]

This issue should be fixed by above commit. Please let me know if you're still seeing any issues. Thanks!