d4nielj / todo-list

Web App that allows the user to keep a list of items in his browser. Made with JavaScript ES2016.

Todo List Web App

Application development for academic purposes.

Screenshot

Live Demo

Live Demo 🙂

Getting Started

Install

• git clone https://github.com/D4nielJ/todo-list.git
• npm install
• npm run start

Test the project

Test the project with Jest

• npm run test

Authors

👤 D4nielJ

• GitHub: @D4nielJ
• LinkedIn: Daniel J

🤝 Contributing

Contributions, issues, and feature requests are welcome!

Feel free to check and add issues to the issues page.

Show your support

Give a ⭐️ if you like this project!

License

This project is licensed under the terms of the MIT license.

todo-list's Issues

P2P code review Jul 16

Code review

Stand-up Team Morning Session [2021/07/22]

Stand-up Team Morning Session [2021/07/22]

Leave your comment below regarding Daniel's code!

JavaScripts bests practices review.

If you use ES6, use object destructuring to get the values from an object. This way you can avoid repeating a lot of code.

I could evaluate each one of the scripts to implement destructuring.

todo-list/src/app/components/appendTask.js

Line 21 in cea5453

>${task.desc}</p>

Also, I'm not sure if I'm following YAGNI principle... But I find it hard to evaluate. Some of the logic could be grouped together to not implement as many modules. Also not particularly sure about KISS. I have the logic and the DOM manipulation in different files. But DOM manipulation doesn't seem as clean or simple.