[v4] Spec directory not included in screenshot path about cypress-visual-regression

[Zaista]

Thanks for raising this issue. Is there any specific need to have this behavior the same as in v3? Because with Cypress' specPattern option it's difficult to predict the location of spec files, hence the base folder was used with no nesting.

In hindsight, the thing I obviously missed is to make this visible for users who upgrade.

[TomaszG]

Personally, I don't, I can live with that :) However, I can imagine a scenario where one has the same spec names in different directories so they will have to remember to use unique snapshot names in specs so they don't conflict across these specs.

[lamberski]

@TomaszG Precisely that. I have this situation right now. In our project, the folder structure is:

/components
    /atoms
    /molecules
    /organisms
    …

Now, if I have both atom and molecule components with the same name (eg. Link), previously, it would replicate the structure of folders, but now, it will mush them together into one.

1. Before:
   • /cypress/component/snapshots/base/components/atoms/Link/Link.test.tsx/External-1024x768.png
   • /cypress/component/snapshots/base/components/molecules/Link/Link.test.tsx/External-1024x768.png
2. After:
   • /cypress/component/snapshots/base/Link.test.tsx/External-1024x768.png
   • /cypress/component/snapshots/base/Link.test.tsx/External-1024x768.png

The path produced in both components is the same.

Currently, we don't face issues because components have unique names. However, this could be problematic in certain situations.

[area73]

Hey @TomaszG , @lamberski I will take a look at this issue soon, Thanks for reporting
cc: @Zaista