Timeout failure for getComment aliases when all the tests are run about cypress-example-kitchensink

[jennifer-shehane]

Yes, this is happening when clicking 'run all tests' and having all specs run tests together.

I am not encountering this error when running the tests that are seeded in the Cypress project itself (added when you create a new project) - which are using the Kitchen-Sink version 1.0.1. This makes me believe that this bug was introduced in one of the commits on this project after May 14, 2018 https://github.com/cypress-io/cypress-example-kitchensink/commits/master

I'm quite confused why our automated tests would not have caught this though.

Can you confirm that you forked the repository and ran it on your own?

Cy Version: 3.0.1
Browser: Chrome 67 / Electron 59
OS: Mac

[jennifer-shehane]

Oh, well, duh, they weren't caught because the specs are run in isolation within CI, not as if you had clicked 'run all tests'

[jennifer-shehane]

I was able to narrow down the bug to these lines of code:

beforeEach(() => {
  cy.visit('http://localhost:8080/commands/files')
})

it('.defaults() - change default config of server', () => {
  Cypress.Server.defaults({
    whitelist (xhr) {
      expect(xhr).to.be.an('object')
    },
  })
})

it('cy.fixture() - load a fixture', () => {
  cy.server()
  cy.route('GET', 'comments/*').as('getComment')
  cy.get('.fixture-btn').click()
  cy.wait('@getComment')
})

[jennifer-shehane]

The assertion below is failing, but failing in a later test - while trying to process the .wait() command.

expect(xhr).to.be.an('object')

[jennifer-shehane]

Ok, so we are going to remove the whitelist sections of the Cypress.Server.default({}).

This isn't really a good use case of how the whitelist feature should be used - ideally you would rewrite the function and not add an arbitrary assertion in here. Because of the way error handling is handled in this case, the error is being pushed off and being thrown on the .wait() command. Which is why all of these waits are failing.

There does not appear to be an error in Cypress itself that we should open an issue for.

[katnem]

@jennifer-shehane to clarify, I haven't forked the repo, I just cloned it and ran the tests from the runner locally (if it makes any difference considering your previous replies).

[katnem]

Thanks @jennifer-shehane =)

[cypress]

---

Test summary

115 • 0 • 0 • 0

---

Run details

Project	cypress-example-kitchensink
Status	Passed
Commit	ab3954793a
Started	Mar 15, 2020 12:10 PM
Ended	Mar 15, 2020 12:17 PM
Duration	06:13 💡
OS	Windows 10.0.17763
Browser	Electron 78

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard