Wrong behaviour of the message "use `collect(pull_tbl())`" about dm

[krlmlr]

Thanks for the reprex. I see two problems here:

• The message that appears with your original use of collect(), mentioning collect(pull_tbl())
• The behavior of collect(pull_tbl()), ignoring the (unused) extra argument pull_tbl()

Two PRs now change this to a better error message (suggesting to use . %>% pull_tbl() %>% collect()), and the following behavior:

con <- DBI::dbConnect(duckdb::duckdb())

dbplyr::copy_nycflights13(con)
#> Creating table: airlines
#> Creating table: airports
#> Creating table: flights
#> Creating table: planes
#> Creating table: weather
flights <- dplyr::tbl(con, "flights")

dm_with_misworded_message <- dm::dm(flights) |>
  dm::dm_zoom_to(flights) |>
  dplyr::collect(dm::pull_tbl())
#> Error in `dplyr::collect()`:
#> ! `...` must be empty.
#> ✖ Problematic argument:
#> • ..1 = dm::pull_tbl()
#> ℹ Did you forget to name an argument?
#> Backtrace:
#>     ▆
#>  1. ├─dplyr::collect(dm::dm_zoom_to(dm::dm(flights), flights), dm::pull_tbl())
#>  2. └─dm:::collect.dm_zoomed(dm::dm_zoom_to(dm::dm(flights), flights), dm::pull_tbl())
#>  3.   └─rlang::check_dots_empty() at dm/R/dm.R:719:2
#>  4.     └─rlang:::action_dots(...)
#>  5.       ├─base (local) try_dots(...)
#>  6.       └─rlang (local) action(...)

DBI::dbDisconnect(con, shutdown = TRUE)

^{Created on 2023-08-14 with reprex v2.0.2}