Coder Social home page Coder Social logo

Comments (8)

ajmchambers avatar ajmchambers commented on June 7, 2024

Not sure why, but adding: "typeRoots" : ["./node_modules/@types"] into the tsconfig.json's "compilerOptions" makes it work.

from create-cycle-app.

ajmchambers avatar ajmchambers commented on June 7, 2024

Some more testing:
The webpack flavour is working fine actually (could have sworn it didn't work for me but its working with a fresh attempt - I may have picked the wrong option or something).

So it may be an issue with the browserify tsify package, this issue seems relevant:
TypeStrong/tsify#208

from create-cycle-app.

geovanisouza92 avatar geovanisouza92 commented on June 7, 2024

@ajmchambers could you confirm which typescript version are you using?

I'm suspicious that this is related to dependencies versions.

Indeed, an npm ls --depth=0 could here from here.

from create-cycle-app.

ajmchambers avatar ajmchambers commented on June 7, 2024
λ npm ls --depth=0
[email protected] C:\Development\test-typescript
+-- @cycle/[email protected]
+-- @cycle/[email protected]
+-- @types/[email protected]
+-- @types/[email protected]
+-- @types/[email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected] extraneous
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
`-- [email protected]

npm ERR! extraneous: [email protected] C:\Development\test-typescript\node_modules\cycle-scripts-ts-browserify

I still think it's a bug with tsify.

I've been running through the debugger in vscode comparing the browserify version against the webpack version and have noticed some differences.

comparison

The browserify version in the left has:
fileName:"node_modules/@cycle/dom/lib/isolateModule.d.ts"

And the webpack version on the right (which is working) has:
fileName:"c:/Development/test-typescript-webpack/node_modules/@cycle/dom/lib/isolateModule.d.ts"

Anyway thats what I've figured out so far, gonna keep poking about to see where the fileName is actually being set.

from create-cycle-app.

ajmchambers avatar ajmchambers commented on June 7, 2024

(just some more notes)

Comparing rootFiles in mac (left) against windows (right):

rootnamescomparison

For some reason the windows side is missing the 3 @types for core-js, mocha, and node.

from create-cycle-app.

ajmchambers avatar ajmchambers commented on June 7, 2024

This has been fixed for me with tsify 2.0.3, closing this issue.

from create-cycle-app.

geovanisouza92 avatar geovanisouza92 commented on June 7, 2024

Good to hear, @ajmchambers! Please, report any other issues you found in the future.

from create-cycle-app.

ajmchambers avatar ajmchambers commented on June 7, 2024

Cheers, will do. (and btw thanks for making this tool, love it)

from create-cycle-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.