Pitch detection is inaccurate about pitchdetect

[Pranoy1c]

I agree with j-funk. Unfortunately, I found this to be extremely inaccurate with my Piano at least. Pressing the A4 (440) shows A4 for a tiny millisecond but then jumps around to E and then disappears. Testing others notes (C4, F4 etc) don't even show correctly and just jump around. So I would not recommend this.

[Tymski]

This is as consistent as tuning my guitar to a random number generator.

[MrRedBeard]

@j-funk @Pranoy1c @Tymski @cwilso @webnard

If you comment out return sampleRate/(best_offset+(8*shift)) under else if (foundGoodCorrelation) the returned frequency is way more stable and accurate at least for notes closer to 440.

} else if (foundGoodCorrelation) { // short-circuit - we found a good correlation, then a bad one, so we'd just be seeing copies from here.

//return sampleRate/(best_offset+(8*shift)); }