Comments (2)
A quick hack to ObjectPackConsumer::ConsumePayload()
fixes this specific issue:
diff --git a/cvmfs/pack.cc b/cvmfs/pack.cc
index f7d635701..a7f86d56e 100644
--- a/cvmfs/pack.cc
+++ b/cvmfs/pack.cc
@@ -338,7 +338,7 @@ ObjectPackBuild::State ObjectPackConsumer::ConsumeNext(
ObjectPackBuild::State ObjectPackConsumer::ConsumePayload(
const unsigned buf_size, const unsigned char *buf) {
uint64_t pos_in_buf = 0;
- while ((pos_in_buf < buf_size) && (idx_ < index_.size())) {
+ while ((pos_in_buf <= buf_size) && (idx_ < index_.size())) {
// Fill the accumulator or process next small object
uint64_t nbytes; // How many bytes are consumed in this iteration
const uint64_t remaining_in_buf = buf_size - pos_in_buf;
but I have not yet reviewed this change to see if it might create other failure cases.
from cvmfs.
but I have not yet reviewed this change to see if it might create other failure cases.
That hack would (I think) have caused an infinite loop in the case of a partial object. I've created what should be a proper fix in #2731
from cvmfs.
Related Issues (20)
- Update pacparser to version 1.4.2 HOT 1
- Update repository statistics generation to latest ROOT
- CVMFS and fuse-overlayfs HOT 1
- Add packages and CI for Debian 12 ("bookworm") HOT 2
- Removal of deep nested catalog hierarchy is slow
- [unpacker] extend the container conversion service by a REST API HOT 1
- cvmfs crashes in posix quota HOT 2
- Review memory consumption for replication
- numerous "failed to read-ahead" messages from GC HOT 1
- Please update cvmfs-contrib-release to version 1.19 HOT 3
- cvmfs_config reload gets stuck HOT 6
- Client: Ignore signature check when downloading HOT 1
- Tmpfs detection not working correctly
- Removing images from unpacked.cern.ch
- Build failure in libarchive on macos 13
- Possible Code Improvements with C++11 HOT 1
- Improve structure/filenames for integration tests HOT 2
- making cvmfs_config stat <org> more robust
- Publisher transactions should survive gateway restart
- sqlite readahead optimisation 2/2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cvmfs.