Coder Social home page Coder Social logo

Comments (4)

hbruch avatar hbruch commented on July 17, 2024

Currently, the server version is already requested in the ServerChecker. Depending on the version, the api version parameter is stored in the preferences, which would be natural to reuse.
As the API version seems to be a concept introduced by otp-for-android and not an official otp value, it could be incremented to reflect this (and perhaps further?) changes in OTP v1.0.

However, current uses of the OTPApp.PREFERENCE_KEY_API_VERSION explicitly compare to version 1 and would need to be adapted, if a new version should be introduced.

Think this would be the best option compared to doing trial and error requests for multiple urls, accessing the server info here again or introducing a new preference value for the server version.

from opentripplanner-for-android.

hbruch avatar hbruch commented on July 17, 2024

The metadata endpoint was removed in otp with commit ac1f29c ("Removed GraphMetadata API point", 2015-06-05), so any otp server version equal to or greater than 0.19 will suffer from this issue.

from opentripplanner-for-android.

barbeau avatar barbeau commented on July 17, 2024

@hbruch Thanks! You're correct, looks like this affects 0.19 and above.

from opentripplanner-for-android.

barbeau avatar barbeau commented on July 17, 2024

Also, I believe this only affects when a server is entered as a custom API - I believe we use the bounds from the OTP Server Directory for those servers.

from opentripplanner-for-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.