Attachment file with non-ASCII characters in name breaks mail header about simple-mail

[dantti]

is "Content-Transfer-Encoding: base64" header missing for the filename, or the file name isn't being encoded?

[steinachim]

The header is missing. The file name and contents are properly encoded.

See below two examples of the same file being sent - a text file with the content "abcdefg", but once the file is named testFile and once testfäöü

Let me know if you need any more info.

Raw mail source for file without umlauts:

...
--3eb453d25e5b4e5f9a4938fc8cb4e189
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

TestBody

--3eb453d25e5b4e5f9a4938fc8cb4e189
Content-Type: text/plain; name="testFile"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="testFile"

YWJjZGVmZwo=
--3eb453d25e5b4e5f9a4938fc8cb4e189--

Raw mail source for file without umlauts:

...
--25a9eab56f03403088b99a221f7d209c
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

TestBody

--25a9eab56f03403088b99a221f7d209c
Content-Type: text/plain; name="testfäöü"
Content-Disposition: attachment; filename="testfäöü"

YWJjZGVmZwo=
--25a9eab56f03403088b99a221f7d209c--

[dantti]

should be fixed by your MR