Coder Social home page Coder Social logo

Comments (4)

sethvargo avatar sethvargo commented on August 12, 2024

cc785e4

@mikelococo can you try master and let me know if it's working?

from hostsfile.

mikelococo avatar mikelococo commented on August 12, 2024

Tested and it looks good. The only other niggle is that the error message when parsing the invalid /etc/hosts file was pretty misleading. I burned a lot of time thinking that my resource declaration was wrong, when it was really happening inside the parse method. It would be handy to raise an exception from the parse method if either hostname or ip is nil with a message that makes it clear the problem is in the existing /etc/hosts file rather than in the cookbook.

from hostsfile.

sethvargo avatar sethvargo commented on August 12, 2024

@mikelococo I do raise an exception, but Chef swallows it

from hostsfile.

mikelococo avatar mikelococo commented on August 12, 2024

That's fun. I assume there also a good reason why the chef logger can't or shouldn't be used from that code context. A more explicit error for parsing problems would be handy, but perhaps not worth effort. It's less likely to arise now that the root cause is fixed.

from hostsfile.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.