Coder Social home page Coder Social logo

Comments (4)

luke-hill avatar luke-hill commented on July 3, 2024

ping @aslakhellesoy if you're around. @mpkorstanje also as a breakout to enable the refactor PR for ruby to be done.

I'll raise this as a discussion point next thurs for others to read/chat on. @davidjgoss / @ehuelsmann spring to mind as obvious ones as well as @WannesFransen1994

from cucumber-expressions.

mpkorstanje avatar mpkorstanje commented on July 3, 2024

Therefore I propose removing all getters and just rely on using the hash methods.

For Ruby only? No problem. I don't know enough about Ruby to make a judgement there.

from cucumber-expressions.

mpkorstanje avatar mpkorstanje commented on July 3, 2024

For the other languages I don't think this is necessarily as good idea.

In general we want to keep the code structure (folders, files, clas names, method names, ect) similar so we can compare the implementations.

And that means we can't use all the best practices for each language. But for Ruby, and this specific change, I don't see a problem because we're not changing the structure.

from cucumber-expressions.

luke-hill avatar luke-hill commented on July 3, 2024

Do you think then maybe just renaming all the getter methods to something diff for that one method end is perhaps the best course of action (Maybe with a comment explaining why?)

from cucumber-expressions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.