Comments (4)
ping @aslakhellesoy if you're around. @mpkorstanje also as a breakout to enable the refactor PR for ruby to be done.
I'll raise this as a discussion point next thurs for others to read/chat on. @davidjgoss / @ehuelsmann spring to mind as obvious ones as well as @WannesFransen1994
from cucumber-expressions.
Therefore I propose removing all getters and just rely on using the hash methods.
For Ruby only? No problem. I don't know enough about Ruby to make a judgement there.
from cucumber-expressions.
For the other languages I don't think this is necessarily as good idea.
In general we want to keep the code structure (folders, files, clas names, method names, ect) similar so we can compare the implementations.
And that means we can't use all the best practices for each language. But for Ruby, and this specific change, I don't see a problem because we're not changing the structure.
from cucumber-expressions.
Do you think then maybe just renaming all the getter methods to something diff for that one method end
is perhaps the best course of action (Maybe with a comment explaining why?)
from cucumber-expressions.
Related Issues (20)
- Return optionals as part of a Cucumber Expression match HOT 4
- java: Not all tests are executed HOT 1
- Remove Python example illustrating how to define parameter types HOT 2
- more powerful optional text HOT 12
- Allow free-form text in optionals HOT 1
- Expression for an argument list HOT 4
- Improve Expression creation performance HOT 2
- Use action-publish-pypi in cucumber-expressions
- Optimize Cucumber expression creation in .Net implementation
- Action Required: Fix Renovate Configuration
- Bad CucumberExpression creation performance HOT 6
- Golang big.Float is not a big decimal HOT 12
- Feature: named capture groups HOT 13
- Missing source for source map
- RegEx "expressions" and defineParameterType feature file examples ?
- Add the ability to ignore a cucumber expression parameter just like a non capturing regex HOT 12
- Nested capture groups are not passed to custom param definition transformer HOT 8
- LICENSE file is empty HOT 1
- Typo in error message for use of alternation inside an optional
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cucumber-expressions.