Coder Social home page Coder Social logo

Comments (6)

msassak avatar msassak commented on September 26, 2024

I'm in favor of removing as many ambiguities from Gherkin the language as is reasonable, and in my opinion this is one of those cases. I don't think making it optional really adds anything, but Examples without a colon and with a description look awkward:

Examples all colors correct

vs.

Examples: all colors correct

Having said that, making the colon optional shouldn't be too hard if we want to avoid breaking features that have already been written.

from gherkin2.

mattwynne avatar mattwynne commented on September 26, 2024

The best would be if we could get a deprecation warning! Can you do that?

from gherkin2.

msassak avatar msassak commented on September 26, 2024

I think so. I'll look into it.

from gherkin2.

msassak avatar msassak commented on September 26, 2024

See http://github.com/msassak/cucumber/commit/044507c1aa7d00ff6e1525bec81d125cd81d4227

I added it to the Tree Walker in Cuke itself. I think it's best this way, as we can deprecate it now in preparation for Gherkin, and we don't need to fiddle with either of the parsers. I couldn't find a good way to provide more context e.g. "Examples group in /path/to/example.feature", but it's blaringly obvious when run with the pretty printer, so I think we should be OK.

from gherkin2.

mattwynne avatar mattwynne commented on September 26, 2024

Nice one. I think that's fine - I remember way back when it changed from 'Scenarios' to 'Examples' without warning and we just had to suck it up and fix all our features, so this is a great improvement on that.

from gherkin2.

msassak avatar msassak commented on September 26, 2024

This is a cucumber issue now: https://rspec.lighthouseapp.com/projects/16211-cucumber/tickets/500-deprecate-examples-keyword-without-a-colon, so I'm closing this ticket.

from gherkin2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.