Comments (6)
This is because Safari doesn't have a bind() function. This is reproducible in my version of Firefox as well. I've fixed this in my fork of twisty.js, I'll send a pull request soon.
from twisty.js.
Yeah, that's annoying. I've fixed it as well, with an anonymous function, so I'll use that for now.
from twisty.js.
Yeah, that's a solution. Personally, I think it would be nice to have access to bind throughout the source code. My "fix" was to copy the definition of Function.prototype.bind from here: https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Function/bind. Your call.
from twisty.js.
I think I would prefer not to port language implementations. If Safari gets bind, though, I agree it would be nicer to switch over.
from twisty.js.
This isn't a huge deal to me, but how is what I'm proposing any different than the duck punching in RequestAnimationFrame.js?
from twisty.js.
It isn't; just more verbose. I think it's fine now (Although maybe it should eventually be separated from the twisty.js source into a utility file - but that's once we have build scripts and stuff).
from twisty.js.
Related Issues (20)
- Lenient parsing modes
- Backwards animation. HOT 2
- Change location information to string index. HOT 1
- Restore mouse support for `touch` branch. HOT 1
- Record the time of each move for touch input
- Rename algSimplify -> simplify, algToMoves -> toMoves, etc. HOT 1
- Allow alg functions to accept strings HOT 1
- Proper spacing around newline HOT 2
- Alg equality checking.
- Alg class (prototypes)
- Support layers in BlockMove
- Default Repeatable amount to 1
- Support Square-1 moves
- Support clock moves
- Make tests run in node.js
- Add a pre-commit hook
- Playback is not deterministically stopping at breakpoints. HOT 1
- Make twisty.js a shining example of best practices and quality code
- Cube state HOT 1
- Switch from flexbox to grid
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twisty.js.