Add /r command, or remove /msg completely to let other plugins (eg. Essentials) handle it. about core

[NiLSPACE]

Another option is to load Essentials before Core. That should work as well. You can do that in the settings.ini file by putting Plugin=Essentials before Plugin=Core.

[NiLSPACE]

Also, I don't think a plugin should remove a feature just because another plugin has that feature too.

[madmaxoft]

There is a hook that is called when a player issues a command; Essentials could use that hook to prevent the Core from even seeing the command. Somewhat hackish, but I think it's the best solution so far (unless we want to move the entire functionality over to the Core, which might be a good idea as well)

[bennasar99]

I'm not happy if I have to remove Essentials features (already removed more than 5 commands), but as /msg is an important command, /r could be implemented into core and /msg removed from Essentials

[NiLSPACE]

But loading Essentials before should fix the problem altogether right?

[bennasar99]

Yes, it should.
Then there is still the error message which appears if a command is asigned to more than 1 plugin.

[madmaxoft]

Consider it not removing a feature. It's more like moving the feature from one plugin to another. This way it's even gonna be accessible to a lot more people by default.

[bennasar99]

Then, move /r to Core?

[madmaxoft]

Yes

[jonfabe]

So peanut gallery chiming in here, Core is already a fairly large plugin code wise, why not consider splitting all the Chat commands currently in Core off into a separate default plugin, say something like Core:Chat? That way if people want to use a different chat handler they can just disable the Core:Chat plugin?

[madmaxoft]

Do you think there will be a different chat plugin? I find it highly unlikely.

[bennasar99]

Moved /r into core

[jonfabe]

Eh, I know there was for bukkit/spigot and given /r was a part of a
different plugin already for MCServer it seems likely that someone at some
point might get the idea that they want their own chat system rather then
the default for whatever reason (say adding separate chat channels like
towny, for instance, which had town/nation channels in addition to the
global channel).

On Sun, Jan 11, 2015 at 2:15 PM, Mattes D [email protected] wrote:

Do you think there will be a different chat plugin? I find it highly
unlikely.

—
Reply to this email directly or view it on GitHub
#118 (comment).

[bennasar99]

That is actually possible with a plugin.
You just need to loop throught all players, and if they match the conditions, send them the message

[jonfabe]

@tonibm19 I know, I was just giving an example for @madmaxoft as to why another plugin writer might create their own chat system and want to disable the chat commands in Core. At any rate, its nothing that has to be addressed currently (and at this point is certainly beyond the scope of this issue), but is just something to keep in mind for the future.

[36451]

Thanks.
Imo, splitting core into more than one plugin sounds good, but would take some time (and possibly create a bit of confusion).