Coder Social home page Coder Social logo

Comments (8)

cstefanache avatar cstefanache commented on August 12, 2024 1

Done! Not a single tag exist in the code at the moment.

The solution was to remove the reference include the typings only at compilation (in order to avoid angular Map & Promise dependencies issue):

tsconfig.json
"files": [
"typings/browser.d.ts"
],

@ADringer can you please do another test run with 0.4.3?

from angular2-img-cropper.

cstefanache avatar cstefanache commented on August 12, 2024

I am on the road at the moment. I will remove it asap and run the tests.

from angular2-img-cropper.

cstefanache avatar cstefanache commented on August 12, 2024

Fixed with 0.4.2 release

from angular2-img-cropper.

cstefanache avatar cstefanache commented on August 12, 2024

comment not removed - I will have to do a 0.4.3 release - sorry

from angular2-img-cropper.

cstefanache avatar cstefanache commented on August 12, 2024

hmmm ... seems that /// comments are a special thing - can you please check with 0.4.2 change to see if everything is ok? Please note that I removed the .ts files from the built package (just like @angular does) and you should switch loading from js files in system.config.js (see plnkr from readme.md)

from angular2-img-cropper.

ADringer avatar ADringer commented on August 12, 2024

Hi,

Thanks for responding so quickly, didn't expect that!

Unfortunately I still get an error when trying to compile my typescript:

node_modules/ng2-img-cropper/src/imageCropper.d.ts(1,1): error TS6053: File 'c:/
Users/BIO276/Source/Repos/administrationportal/node_modules/ng2-img-cropper/typi
ngs/browser.d.ts' not found.

As ImageCropper is still referencing the local typings (although this doesn't exist anymore).

I don't suppose you had a look at the related bug for Angular2-Highcharts? It got resolved but I'm not sure what the actual fix was.

Thanks

from angular2-img-cropper.

ADringer avatar ADringer commented on August 12, 2024

Perfect, that works like a charm! Thanks very much for sorting that out so quickly.

from angular2-img-cropper.

cstefanache avatar cstefanache commented on August 12, 2024

a lesson learnt for me. I will notice the rest of the users

from angular2-img-cropper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.