Coder Social home page Coder Social logo

Comments (5)

mverzilli avatar mverzilli commented on May 29, 2024

I don't think this is desired, so it's a bug. The problem seems to be here: https://github.com/crystal-lang/crystal_lib/blob/master/src/crystal_lib/type_mapper.cr#L244

And judging by the look of the specs: https://github.com/crystal-lang/crystal_lib/blob/master/spec/parser_spec.cr#L181, it seems this case was simply not accounted for.

Do you want to give it a try? It should be a matter of adding a test to parser_spec and then enhancing the crystal_type_name function :).

from crystal_lib.

olbat avatar olbat commented on May 29, 2024

No problem, I'll try to propose a fix today ! (sry for the late answer)

from crystal_lib.

olbat avatar olbat commented on May 29, 2024

Here it is #44 .

(I think there was something wrong in the tests and proposed a fix in my first commit, just let me know if it was a mistake)

from crystal_lib.

mverzilli avatar mverzilli commented on May 29, 2024

Thanks! I'll take a look soon.

from crystal_lib.

mverzilli avatar mverzilli commented on May 29, 2024

Fixed through #44

from crystal_lib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.