Comments (2)
Thanks for digging into this 🫶
I'm wishing we'd implement more of these system functions in Crystal. It's nice and easy to use libc functions, but they have a complexity as well. And there are many pitfalls for using them correctly, demonstrated by the multiple different bugs we have identified in these relatively small pieces of code (#14619, #14615 and this one).
Of course, rolling our own implementation also adds complexity and we need to ensure correctness. We have some prior art to help with that though. And overall the implementations could end up simpler and more efficient. Looking up some string in /etc/passwd
should be easy enough. And we only need to allocate memory for the field we're actually looking for.
Adding nscd might be a bit more complicated, although I'm wondering if that's even much useful anymore... We might just get away without it.
from crystal.
Adding nscd might be a bit more complicated, although I'm wondering if that's even much useful anymore... We might just get away without it.
I think /etc/passwd and /etc/groups will basically always fit into a single 4K memory page, so there's probably no difference to sending a lookup request to nscd over a unix socket (musl also only uses nscd as a fallback, so it's probably alright).
Manually implementing the file parsing also allows us to trivially implement methods like System::User#each
.
from crystal.
Related Issues (20)
- Truncated quotient and remainder
- Loading debug symbols is not thread-safe on Windows HOT 2
- Inverse of `Int#digits`
- `Number#humanize` raises on infinity and NaN
- `bin\crystal run` wrapper does not terminate if interrupts are ignored HOT 4
- `Object#crystal_type_id` returns different value for virtual type in interpreter
- Typing of ivars does not play well with macros HOT 1
- Reduce CI usage
- Crystal compiler error: Element not found (Enumerable::NotFoundError)
- Crystal Compiler error: Module validation failed: GEP base pointer is not a vector or a vector of pointers HOT 1
- Incorrect function args when yield used in argument list HOT 3
- Invalid memory access (signal 11) at address 0x20
- bsearch return unexpected value when using less or equal test HOT 1
- Native text encoding conversions HOT 4
- Exclude the execution of specific examples in `crystal spec`
- OpenSSL 1.1.1 is broken on aarch64-linux-gnu
- Reusing AST nodes in macro `#each` HOT 1
- Bug when assigning variable inside block in while HOT 1
- Faster floating-point finiteness checks
- Add `Char#==(other : String)` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crystal.