Comments (4)
Looks fine and makes sense to me.
For the record: A single hashtable with multiple action/values would be simpler for the user, but I just figured the array of hashtables would be most consistent with how the API works and would require the least amount of work to the module code.
from psfalcon.
Thanks for the suggestion and your feedback! I have added the Action
parameter to both Invoke-FalconAlertAction
and Invoke-FalconIncidentAction
, along with a supporting private function (Test-ActionParameter
) that is used to validate user input.
These changes will be available in the next PSFalcon release.
from psfalcon.
Thanks! I'm out of the office but I will take a look at this next week.
from psfalcon.
I've implemented a draft of your suggestion that uses an array of Hashtable values to supply the name and value. Example:
Invoke-FalconIncidentAction -Action @{ add_tag = 'example_tag' },@{ update_status = 'closed' } -Id <id>,<id>
You can also supply the proper integer value for update_status
like so:
Invoke-FalconIncidentAction -Action @{ add_tag = 'example_tag' },@{ update_status = 40 } -Id <id>,<id>
- How do you feel about that?
- Do you think that is self-explanatory and easy to use?
I chose [hashtable[]]
because I've seen it used in other PowerShell commands, so it fit PowerShell style and was a bit easier for me to validate.
from psfalcon.
Related Issues (20)
- `SendASync` error with `Invoke-FalconDeploy` HOT 5
- [ BUG ] Get-FalconAsset code 400 error offset 10000 and limit 100 HOT 1
- [ BUG ] `Import-FalconConfig` ignores `FirewallGroup` HOT 1
- [ BUG ] `New-FalconReconRule` generating `Invalid Request` error with single rule HOT 4
- [ BUG ] `Receive` commands generate `index out of range` errors even when successful HOT 6
- [ BUG ] `Add-SensorTag` and `Remove-SensorTag` dont append/remove tags even through reboot HOT 4
- [ BUG ] `Write-Result not recognized` when using `Request-FalconToken` HOT 6
- [ ENHANCEMENT ] Add command to overwrite SensorTags instead of appending HOT 4
- [ BUG ] `Get-FalconHost` error on hostname HOT 5
- [ BUG ] `Id` does not match pattern when using `Get-FalconAsset` HOT 2
- [ DOCUMENTATION ] `tags` should be included in the list of available filters for `Get-FalconHost` HOT 1
- [ BUG ] `Import-FalconConfig` improperly assigns non-existent `rule_group_ids` when creating `FilewallPolicy` HOT 1
- {"code":400,"message":"offset 10000 and limit 100 are invalid; offset + limit must be less than or equal to 10000"} HOT 3
- [ QUESTION ] Client Secret as Secure String HOT 1
- [ BUG ] `Get-FalconAlert -All -Detailed` returns `413 - Request Too Large` HOT 2
- [ BUG ] `Index was out of range` error related to RTR sessions HOT 2
- [ BUG ] `New-FalconIoaRule` generates `400` error when following wiki example HOT 1
- [ BUG ] MacOS `SensorTag` commands do not handle uninstallation tokens
- [ ENHANCEMENT ] Force lowercase for `Cid` parameter when using `Add-FalconRole` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from psfalcon.