Composition update weird behaviour about crossplane

[negz]

@daniel-maganto I'm having a hard time following the problem.

It looks like you're applying a manifest with keys, but no values.

It seems like the problem you're seeing is that:

• When you create the Composition, the missing values are set to null.
• When you update a Composition, the missing values are set/reduced to an empty object ({}).

Is that right?

Can you explain why you're providing a manifest with keys but no values? I actually didn't know this was valid YAML, and would have expected it to be rejected.

[daniel-maganto]

Hi @negz , many thanks for your answer and yes that's right.

About these empty keys are later patched like this:

        - combine:
            strategy: string
            string:
              fmt: '%s-%s-executionpolicy'
            variables:
            - fromFieldPath: spec.parameters.family
            - fromFieldPath: spec.resourceConfig.env
          toFieldPath: spec.forProvider.inlinePolicy[0].name
          type: CombineFromComposite
        - combine:
            strategy: string
            string:
              fmt: |
                {
                    "Version": "2012-10-17",
                    "Statement": [
                        {
                            "Action": [
                                "ecr:BatchCheckLayerAvailability",
                                "ecr:BatchGetImage",
                                "ecr:GetAuthorizationToken",
                                "ecr:GetDownloadUrlForLayer",
                                "logs:CreateLogStream",
                                "logs:PutLogEvents",
                                "sts:GetServiceBearerToken"
                            ],
                            "Resource": "*",
                            "Effect": "Allow"
                        },
                        {
                            "Action": "kms:Decrypt",
                            "Resource": "%[1]s",
                            "Effect": "Allow"
                        },
                        {
                            "Action": [
                                "secretsmanager:DescribeSecret",
                                "secretsmanager:GetSecretValue"
                            ],
                            "Resource": %[2]s,
                            "Effect": "Allow"
                        }
                    ]
                }
            variables:
            - fromFieldPath: kmsARN
            - fromFieldPath: secretsJSON
          toFieldPath: spec.forProvider.inlinePolicy[0].policy
          type: CombineFromEnvironment

We start doing in this way checking the AWS Crossplane Blueprints, for instance. I never found which is the proper way, if define a default, leave it empty or not define.

For me, the key problem is that depends what is the moment that you apply a composition you have different results.