script-opts seem to be ignored about mpv-twitch-chat

[CrendKing]

Config files in mpv uses equal sign "=", not colon.

it seems the twitch_client_id isn't even that necessary.

Currently the script is able to retrieve a working client ID from the stream. But again this is all implementation detail from Twitch. This mechanism could fail anytime. In that case, the script will fallback to the configured ID. So I recommend always provide that ID for safety.

[iv4nhoe]

Config files in mpv uses equal sign "=", not colon.

Doesn't make a difference when I use equal signs instead.

show_name works when I hard code it to true in main.lua so it must be related to how the opts are read. Since it also does not work with passing --script-opts=show_name=true to mpv it leads me to believe that the script opts don't make it to the script. Maybe my mpv is too old? It's version 0.34.1.

[CrendKing]

Oh, just noticed your config filename is wrong. It should be mpv_twitch_chat.conf, not twitch.conf. Doc: https://mpv.io/manual/master/#script-location

[iv4nhoe]

Oh, just noticed your config filename is wrong. It should be mpv_twitch_chat.conf, not twitch.conf. Doc: https://mpv.io/manual/master/#script-location

This mostly did the trick. Another issue was that I was putting spaces around the equal signs which it does not like and that I used true/false instead of yes/no.

The only remaining issue is that it does not recognize the twitch_client_id option.

[CrendKing]

The only remaining issue is that it does not recognize the twitch_client_id option.

As I said, it is working as expected, that your provided option will be used when Twitch stop giving out a working ID from their API.

[iv4nhoe]

The only remaining issue is that it does not recognize the twitch_client_id option.

As I said, it is working as expected, that your provided option will be used when Twitch stop giving out a working ID from their API.

Sorry about the confusion, this is a new issue I'm talking about. When I put twitch_client_id in the config it tells me [mpv_twitch_chat] script-opts/mpv_twitch_chat.conf:1 unknown key 'twitch_client_id', ignoring when starting mpv.

[CrendKing]

Should be fixed now.

[iv4nhoe]

Should be fixed now.

I'm getting an error with this now:

[mpv_twitch_chat] 
[mpv_twitch_chat] stack traceback:
[mpv_twitch_chat]       [string "/home/ivanhoe/.config/mpv/scripts/mpv-twitch-chat..."]:134: in function 'load_twitch_chat'
[mpv_twitch_chat]       [string "/home/ivanhoe/.config/mpv/scripts/mpv-twitch-chat..."]:221: in function 'timer_callback'
[mpv_twitch_chat]       [string "/home/ivanhoe/.config/mpv/scripts/mpv-twitch-chat..."]:249: in function 'prop'
[mpv_twitch_chat]       mp.defaults:407: in function 'handler'
[mpv_twitch_chat]       mp.defaults:510: in function 'call_event_handlers'
[mpv_twitch_chat]       mp.defaults:555: in function 'dispatch_events'
[mpv_twitch_chat]       mp.defaults:503: in function <mp.defaults:502>
[mpv_twitch_chat]       [C]: in ?
[mpv_twitch_chat]       [C]: in ?
[mpv_twitch_chat] Lua error: [string "/home/ivanhoe/.config/mpv/scripts/mpv-twitch-chat..."]:134: attempt to index field 'data' (a nil value)

EDIT:
This seems to be unrelated to your change and to the twitch_client_id. No idea why I'm seeing this now, but not before.

EDIT 2:
Oh wait if I put back nil for the twitch_client_id option in main.lua the stack traceback goes away.

[CrendKing]

Sorry about that. Try now.

[iv4nhoe]

Sorry about that. Try now.

Ok thanks, it works now (as in it puts out an error message that indicates that something with my client id is wrong).

[Tallefer]

I have the same-ish issue: no matter what I do, parameters from the *.conf are ignored.
Not even sure it's this script's problem, but no other script had similar issues before, including older versions of it!
Normally I use the script as twitch-chat-vod.lua to differentiate from other twitch-related stuff (obviously, config is renamed accordingly in all cases), but even if I git clone this repo from scratch and make it work from its own subdir in ~/.config/mpv/scripts, there are no changes.
Tried switching true/yes and false/no (taking wild guesses from older issues here), even tried : instead of =, nope, nothing, not even any errors in console, so I assume the config is not even processed? And surely enough, hard-coding values into the script always work. No relevant files have different permissions from any others.

Some hopefully helpful hints: the script stopped working roughly about 1-2 years back when I switched to a newer MX-linux build and a newer mpv (probably 0.34), but I didn't pay much attention to that because of very little script's usage at the time. Then this year I switched to 0.35 and when I loaded a random vod ~last week - suddenly there were comments, placed as normal subs ofc. I added a twitch profile to mpv.conf so that's not a problem.
BTW, I suggest making a small change to the profile detection code to make it work in the mobile version:
profile-cond=get("path", ""):find("^https?://[wm]w?w?.twitch.tv/") ~= nil

And another small note: when any vod is loaded on pause or being played at faster speeds/seeked, the total number of subs counter in the lower right is incremented, is this the expected behavior? I think it wasn't before.