Consider updating to simdjson 0.2.0 about simdjson_php

[crazyxman]

Updated simdjson to version 0.2.1

[crazyxman]

@lemire Thanks! I will update the native bindings.

[1ma]

I'm very interested in this update, especially the wider range of CPU support.

I tried to update the amalgamation files to 0.2.1 and submit a PR but ultimately I couldn't make it work.

[lemire]

@1ma What was the issue?

Note: we made minor changes to the simdjson API.

[1ma]

Yup I saw one, ParsedJson::isValid() was renamed to ParsedJson::is_valid().

But I'm not fluent in C/C++, I don't have appropriate tooling for the language and after that I still had to make sense of these errors 😅 https://gist.github.com/1ma/7c7329ff57c9b70b02ad81b326311d08

Moreover, in bindings.h and bindings.cpp there is an #ifdef __AVX2__ directive wrapping the whole content of the files that I guess that now should be removed or refactored somehow.

[lemire]

Yes! We don’t require AVX anymore.

[1ma]

I cannot build the latest commit under Alpine Linux 3.10, getting these errors:

$ make
/bin/sh /root/simdjson_php/libtool --mode=compile cc  -I. -I/root/simdjson_php -DPHP_ATOM_INC -I/root/simdjson_php/include -I/root/simdjson_php/main -I/root/simdjson_php -I/usr/include/php7 -I/usr/include/php7/main -I/usr/include/php7/TSRM -I/usr/include/php7/Zend -I/usr/include/php7/ext -I/usr/include/php7/ext/date/lib  -DHAVE_CONFIG_H  -g -O2   -c /root/simdjson_php/simdjson.c -o simdjson.lo 
mkdir .libs
 cc -I. -I/root/simdjson_php -DPHP_ATOM_INC -I/root/simdjson_php/include -I/root/simdjson_php/main -I/root/simdjson_php -I/usr/include/php7 -I/usr/include/php7/main -I/usr/include/php7/TSRM -I/usr/include/php7/Zend -I/usr/include/php7/ext -I/usr/include/php7/ext/date/lib -DHAVE_CONFIG_H -g -O2 -c /root/simdjson_php/simdjson.c  -fPIC -DPIC -o .libs/simdjson.o
In file included from /root/simdjson_php/simdjson.c:23:
/root/simdjson_php/src/bindings.h:25:1: error: unknown type name 'namespace'; did you mean 'isspace'?
 namespace simdjsonphp {
 ^~~~~~~~~
 isspace
/root/simdjson_php/src/bindings.h:25:23: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
 namespace simdjsonphp {
                       ^
/root/simdjson_php/src/bindings.h:41:1: error: unknown type name 'bool'; did you mean '_Bool'?
 bool cplus_simdjson_isvalid(const char *json);
 ^~~~
 _Bool
/root/simdjson_php/simdjson.c:56:22: error: conflicting types for 'cplus_simdjson_isvalid'
 extern unsigned char cplus_simdjson_isvalid(const char *json);
                      ^~~~~~~~~~~~~~~~~~~~~~
In file included from /root/simdjson_php/simdjson.c:23:
/root/simdjson_php/src/bindings.h:41:6: note: previous declaration of 'cplus_simdjson_isvalid' was here
 bool cplus_simdjson_isvalid(const char *json);
      ^~~~~~~~~~~~~~~~~~~~~~
make: *** [Makefile:193: simdjson.lo] Error 1

Commit a0e942d from May 29th builds fine.

If you want to try to reproduce, I started from a clean alpine:3.10 Docker container and only needed to install these packages: apk add git build-base php7-dev

[lemire]

@1ma This looks like one is trying to compile C++ as if it were C... right?

[lemire]

@1ma It might be useful to open a distinct issue regarding build problems?

[1ma]

You are right, sorry.

[lemire]

I suggest we close this issue.