Icon in dark Theme is not visible about vacationdays

[amarradi]

Hey, Ja das ist kein Problem. Yes thats no Problem, but Not today we are planning our holiday Mein Krebstagebuch: https://www.marcusradisch.de CrazyMarvin ***@***.***> schrieb am Fr., 22. Juli 2022, 10:41:

…

Thanks for noticing this. 👍 Are you available to fix this (and maybe #60 <#60>)? — Reply to this email directly, view it on GitHub <#59 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFP5PLPPQJYBLF2OY3SPYDVVJNFNANCNFSM54KNPVIQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[CrazyMarvin]

Thanks for noticing this. 👍
Are you available to fix this (and maybe #60)?

[amarradi]

i tried to checkout an new branch but i need the permission, that i can push to you and you can merge it.

[CrazyMarvin]

i tried to checkout an new branch but i need the permission, that i can push to you and you can merge it.

To which branch did you try to push? The trunk (master branch) is protected but the default branch development should work.

[CrazyMarvin]

For a pull request (PR) you have to make the changes in your own copy/fork and from there you can open a PR to this repository. Check this for more info.

[amarradi]

[marcus@thinkpad VacationDays]$ git push origin development
remote: Permission to Crazy-Marvin/VacationDays.git denied to amarradi.
fatal: konnte nicht auf 'https://github.com/Crazy-Marvin/VacationDays/' zugreifen: The requested URL returned error: 403

The Errormessage

[CrazyMarvin]

OK, I will give you the permission for now.
But the usual process would be to do a fork (it would appear in your account like https://github.com/amarradi/VacationDays) and a PR afterwards.

[CrazyMarvin]

You may accept the invitation and try to push again. 👌

[amarradi]

It is ready you can remove the write permissions again

[CrazyMarvin]

Thank you very much for your help! 👍

[amarradi]

When will you release a final version?

[CrazyMarvin]

When will you release a final version?

This weekend I suppose. I would like to include the fix for #47 too.