Coder Social home page Coder Social logo

Comments (2)

leemcd56 avatar leemcd56 commented on September 23, 2024 1

Update: Did a little looking around and found out the request validator in app/Requests/DatabaseEnvironmentRequest.php catches this. I don't believe it should have a max length because someone could connect to an external database.

In app\Space\EnvironmentManager.php there is a check on line 57 for database tables, but this command does not work in Postgres. When using \Schema::hasTable('users') instead (to check for preexisting migration) I was able to proceed with setup. It also successfully prevents setup if the database is already populated.

from crater.

mohitpanjwani avatar mohitpanjwani commented on September 23, 2024 1

Update: Did a little looking around and found out the request validator in app/Requests/DatabaseEnvironmentRequest.php catches this. I don't believe it should have a max length because someone could connect to an external database.

In app\Space\EnvironmentManager.php there is a check on line 57 for database tables, but this command does not work in Postgres. When using \Schema::hasTable('users') instead (to check for preexisting migration) I was able to proceed with setup. It also successfully prevents setup if the database is already populated.

Thanks for reporting the issue. We've removed the hostname validation of 50 characters to allow larger values.

Also, we've added a prefix to all the crater related tables and updated the DB Check to \Schema::hasTable('cr_users') so users can install crater in existing databases ( not forcing them to create a new DB specifically for crater).

Above changes will be added in the next update.

from crater.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.